Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security fix: Backport security fixes from WC 3.5.8 #230

Merged
merged 7 commits into from
May 4, 2020
Merged

Security fix: Backport security fixes from WC 3.5.8 #230

merged 7 commits into from
May 4, 2020

Conversation

timbocode
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Backport security fixes from woocommerce/woocommerce@3.5.7...3.5.8

WC Commit IDs

woocommerce/woocommerce@1ef2739
woocommerce/woocommerce@2ecf61a
woocommerce/woocommerce@c39e0dc
woocommerce/woocommerce@e0382c5
woocommerce/woocommerce@211d9bf
woocommerce/woocommerce@70610f5
woocommerce/woocommerce@67fa997

Files changed

assets/js/admin/users.js
assets/js/admin/users.min.js
assets/js/frontend/single-product.js
assets/js/frontend/single-product.min.js
assets/js/selectWoo/selectWoo.full.js
assets/js/selectWoo/selectWoo.full.min.js
assets/js/selectWoo/selectWoo.js
assets/js/selectWoo/selectWoo.min.js
includes/admin/class-wc-admin-assets.php
includes/admin/class-wc-admin-setup-wizard.php
includes/class-wc-frontend-scripts.php

See also #214

@timbocode timbocode added this to the 1.0.0-beta1 milestone Mar 1, 2020
@codecov-io
Copy link

Codecov Report

Merging #230 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #230   +/-   ##
=========================================
  Coverage     40.82%   40.82%           
  Complexity    13447    13447           
=========================================
  Files           367      367           
  Lines         51277    51277           
=========================================
  Hits          20936    20936           
  Misses        30341    30341
Impacted Files Coverage Δ Complexity Δ
includes/class-wc-frontend-scripts.php 0% <0%> (ø) 73 <0> (ø) ⬇️
includes/admin/class-wc-admin-assets.php 0% <0%> (ø) 46 <0> (ø) ⬇️
includes/admin/class-wc-admin-setup-wizard.php 0% <0%> (ø) 138 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548ee48...351c412. Read the comment docs.

@timbocode
Copy link
Contributor Author

Testing

  • Checked operation of elements using States select box and fields using selectWoo. All OK.

@timbocode timbocode added the Security Security fixes including WC backports label Mar 8, 2020
@timbocode timbocode requested a review from nylen March 10, 2020 20:27
@timbocode timbocode requested review from bahiirwa and removed request for nylen May 2, 2020 10:38
Copy link
Collaborator

@bahiirwa bahiirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing done. The wizard and user boxes work as expected.

@timbocode timbocode merged commit c3efb7f into ClassicPress:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Security Security fixes including WC backports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants