Fixes #84 + Fixes #110 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The run folder was being set as the source for the
ScriptModContainer::source, which introduced the.minecraftfolder as a classpath for the class loader.AgriCraft uses the
org.reflectionslibrary which compiles all the paths and searches resources through all of them, the source that GroovyScript puts in comes up first, leading to a relative path ofconfig/agricraft/json/defaultswhen AgriCraft always expects it in its own jar which is justjson/defaults, hence every time the path is being resolved, it appendsconfig/agricraft/before it.