Web SDK Release v1.11.1 (#282)

* fix: account id was undefined (#274) * Web Push Prompt css fix (#276) * Updated font size and font-weight * Corrected styling for web push prompt box * Additional Triggers and Clicks for Web Popup (#278) * Added additional triggers and click logic. Refactored tr.js * handle preview cases * handling dismissSpamControl Logic * delay handling in exit intent * removed console log * fix: added chanelogs * feat: updated SDK to 1.11.0 * fix: updated package json version * Web Push prompt button styling fix (#281) * prompt button style fix * prompt css fix * Fixed image styling * Web Popup delay bugfix (#280) * Web Popup delay bugfix * changelog and package json update * Updated changelog * Updated build files --------- Co-authored-by: Yusuf Khan <[email protected]> Co-authored-by: kkyusuftk <[email protected]> Co-authored-by: raghav.gupta <[email protected]> Co-authored-by: Raghav Gupta <[email protected]>
CleverTap · Oct 16, 2024 · 7420a8c · 7420a8c
1 parent 5a9b663
commit 7420a8c
Show file tree

Hide file tree

Showing 8 changed files with 29 additions and 24 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,9 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
+## [1.11.1] - 16 Oct, 2024
+- Fixes a bug where delay was not working for Web Popup Campaigns
+
 ## [1.11.0] - 14 Oct, 2024
 - Adds Additional triggers and clicks handling for Web Popup template
 - Adds a fix for account id undefined for visual editor

diff --git a/clevertap.js b/clevertap.js
diff --git a/clevertap.js.map b/clevertap.js.map
diff --git a/clevertap.min.js b/clevertap.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "clevertap-web-sdk",
-  "version": "1.11.0",
+  "version": "1.11.1",
   "description": "",
   "main": "clevertap.js",
   "scripts": {

diff --git a/src/modules/webPushPrompt/prompt.js b/src/modules/webPushPrompt/prompt.js
@@ -65,13 +65,11 @@ export const createNotificationBox = (configData) => {
   const pnCard = createElementWithAttributes('div', { id: 'pnCard' })
 
   const iconTitleDescWrapper = createElementWithAttributes('div', { id: 'iconTitleDescWrapper' })
-  const iconContainer = createElementWithAttributes('div', { id: 'iconContainer' })
-  const imgElement = createElementWithAttributes('img', {
-    id: 'imgElement',
+  const iconContainer = createElementWithAttributes('img', {
+    id: 'iconContainer',
     src: content.icon.type === 'default' ? `data:image/svg+xml;base64,${PROMPT_BELL_BASE64}` : content.icon.url
   })
 
-  iconContainer.appendChild(imgElement)
   iconTitleDescWrapper.appendChild(iconContainer)
 
   const titleDescWrapper = createElementWithAttributes('div', { id: 'titleDescWrapper' })

diff --git a/src/modules/webPushPrompt/promptStyles.js b/src/modules/webPushPrompt/promptStyles.js
@@ -31,6 +31,7 @@ export const getBoxPromptStyles = (style) => {
         border-color: ${style.card.border.borderColor};
         border-style: solid;
       ` : ''}
+      height: fit-content;
     }
 
     #iconTitleDescWrapper {
@@ -40,9 +41,11 @@ export const getBoxPromptStyles = (style) => {
       gap: 12px;
     }
 
-    #imgElement {
+    #iconContainer {
+      min-width: 64px;
       max-width: 64px;
-      max-height: 64px;
+      aspect-ratio: 1;
+      object-fit: cover;
     }
 
     #titleDescWrapper {
@@ -69,18 +72,23 @@ export const getBoxPromptStyles = (style) => {
     #buttonsContainer {
       display: flex;
       justify-content: space-between;
-      height: 32px;
+      min-height: 32px;
       gap: 8px;
+      align-items: center;
     }
 
     #primaryButton, #secondaryButton {
-      padding: 16px;
+      padding: 6px 24px;
       flex: 1;
       cursor: pointer;
       font-weight: bold;
       display: flex;
       align-items: center;
       justify-content: center;
+      height: max-content;
+      font-size: 14px;
+      font-weight: 500;
+      line-height: 20px;
     }
 
     #primaryButton {
@@ -100,7 +108,7 @@ export const getBoxPromptStyles = (style) => {
       background-color: ${style.buttons.secondaryButton.buttonColor};
       color: ${style.buttons.secondaryButton.textColor};
       border-radius: ${style.buttons.secondaryButton.borderRadius}px;
-      ${style.buttons.primaryButton.borderEnabled
+      ${style.buttons.secondaryButton.borderEnabled
         ? `
           border-width: ${style.buttons.secondaryButton.border.borderWidth}px;
           border-color: ${style.buttons.secondaryButton.border.borderColor};

diff --git a/src/util/tr.js b/src/util/tr.js
@@ -182,7 +182,7 @@ const _tr = (msg, {
     }
     // delay
     const displayObj = targetingMsgJson.display
-    if (displayObj.wtarget_type === 1 && displayObj.delay != null && displayObj.delay > 0) {
+    if (displayObj.delay != null && displayObj.delay > 0) {
       const delay = displayObj.delay
       displayObj.delay = 0
       setTimeout(_tr, delay * 1000, msg, {