Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing enable api testing #338

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

removing enable api testing #338

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
080368b
removing enable api testing
rohitniyerclevertap Jan 21, 2025
517924d
Removed console
rohitniyerclevertap Jan 21, 2025
db719d5
check for swerviceworkerpath and skipdialog
rohitniyerclevertap Jan 22, 2025
7d16a5c
Testing, removed card when ebell icon rejects browser native
rohitniyerclevertap Jan 22, 2025
28f9da7
Merge pull request #340 from CleverTap/develop
singhkunal2050 Jan 28, 2025
3a01657
[WEB-3414]: reverted to old api
rohitniyerclevertap Jan 28, 2025
c35a46e
resolved comments
rohitniyerclevertap Jan 28, 2025
2e26039
Merge branch 'master' of github.com:CleverTap/clevertap-web-sdk into …
rohitniyerclevertap Jan 29, 2025
253b652
Fixed appilcationServerKey, subscriptionCallback, rejectCallback, okC…
rohitniyerclevertap Jan 29, 2025
4922ba1
removed console
rohitniyerclevertap Jan 29, 2025
b697bd1
Code rabbit review comments, fixed changes
rohitniyerclevertap Jan 30, 2025
0bf9c64
Added comments
rohitniyerclevertap Jan 30, 2025
f2edf61
renmaed notificationPushCalled variable
rohitniyerclevertap Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
228 changes: 197 additions & 31 deletions clevertap.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion clevertap.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion clevertap.min.js
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 7 additions & 1 deletion src/clevertap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ import { hasWebInboxSettingsInLS, checkAndRegisterWebInboxElements, initializeWe
import { Variable } from './modules/variables/variable'
import VariableStore from './modules/variables/variableStore'
import { checkBuilder, addAntiFlicker } from './modules/visualBuilder/pageBuilder'
import { setServerKey } from './modules/webPushPrompt/prompt'
import { processSoftPrompt, setServerKey } from './modules/webPushPrompt/prompt'

export default class CleverTap {
#logger
Expand Down Expand Up @@ -548,7 +548,13 @@ export default class CleverTap {
}
api.enableWebPush = (enabled, applicationServerKey) => {
setServerKey(applicationServerKey)
StorageManager.saveToLSorCookie('applicationServerKeyReceived', true)
this.notifications._enableWebPush(enabled, applicationServerKey)
const isWebPushConfigPresent = StorageManager.readFromLSorCookie('webPushConfigResponseReceived')
const isNotificationPushCalled = StorageManager.readFromLSorCookie('notificationPushCalled')
if (isWebPushConfigPresent && isNotificationPushCalled) {
processSoftPrompt()
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider adding error handling for storage operations.

Storage operations could fail in private browsing mode or when storage is full. Consider wrapping the storage operations in try-catch blocks.

-      StorageManager.saveToLSorCookie('applicationServerKeyReceived', true)
-      this.notifications._enableWebPush(enabled, applicationServerKey)
-      const isWebPushConfigPresent = StorageManager.readFromLSorCookie('webPushConfigResponseReceived')
-      const isNotificationPushCalled = StorageManager.readFromLSorCookie('notificationPushCalled')
-      if (isWebPushConfigPresent && isNotificationPushCalled) {
-        processSoftPrompt()
-      }
+      try {
+        StorageManager.saveToLSorCookie('applicationServerKeyReceived', true)
+        this.notifications._enableWebPush(enabled, applicationServerKey)
+        const isWebPushConfigPresent = StorageManager.readFromLSorCookie('webPushConfigResponseReceived')
+        const isNotificationPushCalled = StorageManager.readFromLSorCookie('notificationPushCalled')
+        if (isWebPushConfigPresent && isNotificationPushCalled) {
+          processSoftPrompt()
+        }
+      } catch (error) {
+        logger.error('Failed to process web push setup:', error)
+        // Fallback: Enable web push without soft prompt
+        this.notifications._enableWebPush(enabled, applicationServerKey)
+      }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
StorageManager.saveToLSorCookie('applicationServerKeyReceived', true)
this.notifications._enableWebPush(enabled, applicationServerKey)
const isWebPushConfigPresent = StorageManager.readFromLSorCookie('webPushConfigResponseReceived')
const isNotificationPushCalled = StorageManager.readFromLSorCookie('notificationPushCalled')
if (isWebPushConfigPresent && isNotificationPushCalled) {
processSoftPrompt()
}
try {
StorageManager.saveToLSorCookie('applicationServerKeyReceived', true)
this.notifications._enableWebPush(enabled, applicationServerKey)
const isWebPushConfigPresent = StorageManager.readFromLSorCookie('webPushConfigResponseReceived')
const isNotificationPushCalled = StorageManager.readFromLSorCookie('notificationPushCalled')
if (isWebPushConfigPresent && isNotificationPushCalled) {
processSoftPrompt()
}
} catch (error) {
logger.error('Failed to process web push setup:', error)
// Fallback: Enable web push without soft prompt
this.notifications._enableWebPush(enabled, applicationServerKey)
}

}
api.tr = (msg) => {
_tr(msg, {
Expand Down
Loading
Loading