Interpret config file/args as relative to pkg_dir #1133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interpret the config file path as relative to the ClimaCOupler.jl package. Do the same for the restart_dir and coupler_output_dir in the config. This enables `run_amip` to also be run from `experiments/ClimaEarth` with the default config path and without modifying the usual output path.
Sbozzolo
reviewed
Dec 23, 2024
| @@ -139,7 +139,7 @@ postprocessing and the conservation checks) of the simulation will be saved, | |||
| #and `dir_paths.checkpoints`, where restart files are saved. | |||
| =# | |||
|
|
|||
| COUPLER_OUTPUT_DIR = joinpath(output_dir_root, job_id) | |||
| COUPLER_OUTPUT_DIR = joinpath(pkg_dir, output_dir_root, job_id) | |||
There was a problem hiding this comment.
I don't think it should not be relative to pkg_dir. pkg_dir could be inside the .julia in the user's home directory. This is a hidden folder, with possibly storage quotas. It is not a great place where to save files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This addressed the "make sure output dir doesn't end up being experiments/ClimaEarth/experiments/ClimaEarth/... when run from exp/ClimaEarth/ directory" point from issue #1122
To-do
Content
Interpret the config file path as relative to the
ClimaCoupler.jl package. Do the same for the restart_dir and coupler_output_dir in the config.
This enables
run_amipto also be run fromexperiments/ClimaEarthwith the default config path and without modifying the usual output path.