Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arctic_night.jl for latest Oceananigans #325

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update arctic_night.jl for latest Oceananigans #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
57c094c
Update arctic_night.jl
glwagner Jan 8, 2025
b1158db
Update idealized_single_column_simulation.jl
glwagner Jan 8, 2025
e7eb42c
Merge branch 'main' into glw/update-arctic-night
navidcy Jan 19, 2025
1e2312b
Merge branch 'main' into glw/update-arctic-night
navidcy Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/arctic_night.jl
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gee - this is the precisely the same code as for idealized_single_column_formulation.jl - see the .mp4 at the end for example. I saw this because the same buoyancy error occcured in both arctic_night.jl and this example.
Please let us have the actual arctic_night.jl !

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I think this script was actually added to the repo by mistake! But what do you mean by this:

Please let us have the actual arctic_night.jl !

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference between this script and the "idealized single column formulation" is the inital ocean temperature (0 C instead of 20 C) and the atmos temperature (-5 C in arctic night). I think this one also has sea ice which we expect to grow under these conditions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I did miss those differences. I will explore the git tool for checking them. Suggestion: change the name of the .mp4 output file to say arctic_night.mp4 .

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you submit a PR with that change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my time is too limited, could someone else please do this?

The change needed is to replace in line 114 of the file arctic_night.jl of the examples directory the filename "idealized_atmosphere.mp4"
by "arctic_night.mp4" or similar. Thanks.

Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ parent(atmosphere.downwelling_radiation.shortwave) .= Qℓ # W
grid = RectilinearGrid(size=400, z=(-400, 0), topology=(Flat, Flat, Bounded))
ocean = ocean_simulation(grid, coriolis=FPlane(; f))

eos = ocean.model.buoyancy.model.equation_of_state
g = ocean.model.buoyancy.model.gravitational_acceleration
eos = ocean.model.buoyancy.formulation.equation_of_state
g = ocean.model.buoyancy.formulation.gravitational_acceleration
α = SeawaterPolynomials.thermal_expansion(T₀, S₀, 0, eos)
dTdz = N² / (α * g)
Tᵢ(z) = max(-1.8, T₀ + dTdz * z)
Expand Down
4 changes: 2 additions & 2 deletions examples/idealized_single_column_simulation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ parent(atmosphere.downwelling_radiation.shortwave) .= Qℓ # W
grid = RectilinearGrid(size=100, z=(-400, 0), topology=(Flat, Flat, Bounded))
ocean = ocean_simulation(grid, coriolis=FPlane(; f))

eos = ocean.model.buoyancy.model.equation_of_state
g = ocean.model.buoyancy.model.gravitational_acceleration
eos = ocean.model.buoyancy.formulation.equation_of_state
g = ocean.model.buoyancy.formulation.gravitational_acceleration
α = SeawaterPolynomials.thermal_expansion(T₀, S₀, 0, eos)
dTdz = N² / (α * g)
Tᵢ(z) = T₀ + dTdz * z
Expand Down
Loading