Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking forcing functions #370

Merged
merged 3 commits into from
Aug 27, 2019
Merged

Benchmarking forcing functions #370

merged 3 commits into from
Aug 27, 2019

Conversation

ali-ramadhan
Copy link
Member

This should help us figure out how to write efficient forcing functions. Important as they're used by the Europa and seasonal cycle simulations to implement relaxation terms at the boundaries.

X-ref: #365

@ali-ramadhan ali-ramadhan added performance 🏍️ So we can get the wrong answer even faster GPU 👾 Where Oceananigans gets its powers from labels Aug 27, 2019
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #370 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   74.74%   74.74%           
=======================================
  Files          22       22           
  Lines        1176     1176           
=======================================
  Hits          879      879           
  Misses        297      297

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d4004...f870e57. Read the comment docs.

@glwagner
Copy link
Member

I'm happy to merge this --- though are we sure we need this as a permanent part of the code? When we write the documentation, we can use this script to develop our tips and then decide whether or not we want to keep it after that.

@glwagner glwagner merged commit b3ef76a into master Aug 27, 2019
@glwagner glwagner deleted the benchmark-forcing branch August 27, 2019 14:32
@ali-ramadhan
Copy link
Member Author

Sounds like a good idea. Should come in handy for developing those tips.

I think we should have a pretty sophisticated benchmarking suite that runs as part of CI, which should include benchmarking forcing functions. We just don't have a place to run these benchmarks right now, although SlurmCI (see PR #280) is an option now.

arcavaliere pushed a commit to arcavaliere/Oceananigans.jl that referenced this pull request Nov 6, 2019
Benchmarking forcing functions

Former-commit-id: b3ef76a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GPU 👾 Where Oceananigans gets its powers from performance 🏍️ So we can get the wrong answer even faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants