(0.2.0) Pencil decomposition for the TripolarGrid #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hericalShellGrids.jl into ss/double-distributed
|
Apparently, using MPI in GitHub actions is trivial, we just need to launch the example with |
simone-silvestri
changed the title
…hericalShellGrids.jl into ss/double-distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces pencil decomposition (in x and y) for the tripolar grid, contingent on having a even number of processors in the x-direction.
Also fixes some bugs in the previously untested y-slab partitioning and adds tests for the distributed tripolar grid.
Tests have been added and everything seems to work nicely.
However, this PR depends on PR CliMA/Oceananigans.jl#3714, so I will work on the Oceananigans PR, then we can look at this one.