Catch division by zero in SecantMethod
#56
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haakon-e
force-pushed
the
he/root-errors
branch
from
7afc4be to
fd201d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some (likely rare) instances, especially working with
Float32, it's possible to get the same valuey=f(x)for two successivex0, x1. In this case, a division-by-zero would occur, resulting in garbage output despite the possibility of already having converged.This PR catches this edge case, and returns the current state. The method will be declared converged if
abs(x1-x0)is small, otherwise it will be declared not converged (but still return).