Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix existing broken hashes on main-repo which cause htmltest to fail #74277

Merged
merged 11 commits into from
Jan 9, 2025

Conversation

Blargian
Copy link
Member

@Blargian Blargian commented Jan 7, 2025

Fixes existing broken hashes which are detected by htmltest. See here.

Changelog category (leave one):

  • Documentation (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing)

All builds in Builds_1 and Builds_2 stages are always mandatory
and will run independently of the checks below:

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs

  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64
  • Exclude: All with release
  • Exclude: All with debug

  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, BuzzHouse, etc.)
  • Exclude: AST fuzzers

  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@Blargian Blargian requested a review from gingerwizard January 7, 2025 21:05
@@ -1961,8 +1961,6 @@ Note we sort by code contributions. Surprisingly high % for all our largest cont

To compute this by author is trivial,

[play](#U0VMRUNUCiAgICBhdXRob3IsCiAgICBjb3VudElmKGxpbmVfdHlwZSA9ICdDb2RlJykgQVMgY29kZV9saW5lcywKICAgIGNvdW50SWYoKGxpbmVfdHlwZSA9ICdDb21tZW50JykgT1IgKGxpbmVfdHlwZSA9ICdQdW5jdCcpKSBBUyBjb21tZW50cywKICAgIGNvZGVfbGluZXMgLyAoY29tbWVudHMgKyBjb2RlX2xpbmVzKSBBUyByYXRpb19jb2RlLAogICAgdG9TdGFydE9mV2Vlayh0aW1lKSBBUyB3ZWVrCkZST00gZ2l0X2NsaWNraG91c2UubGluZV9jaGFuZ2VzCkdST1VQIEJZCiAgICB0aW1lLAogICAgYXV0aG9yCk9SREVSIEJZCiAgICBhdXRob3IgQVNDLAogICAgdGltZSBBU0MKTElNSVQgMTA=)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will add this back after ClickHouse/sql.clickhouse.com#9

@Blargian Blargian added the can be tested Allows running workflows for external contributors label Jan 7, 2025
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-documentation Documentation PRs for the specific code PR label Jan 7, 2025
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented Jan 7, 2025

This is an automated comment for commit b58b1ac with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Docs checkBuilds and tests the documentation✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@Blargian
Copy link
Member Author

Blargian commented Jan 8, 2025

@DamianMaslanka5 @Felixoid could we revert the changes in #73705 ? I see there is a note in docs_check.py to remove some code once all the broken hashes are fixed. I believe all are fixed now, and it's now failing on hashes which I cannot even find in the code.

@Felixoid
Copy link
Member

Felixoid commented Jan 8, 2025

I'd suggest fixing them.

In this case, we need to search in https://github.com/ClickHouse/clickhouse-docs/, and there are the anchors we need to fix:

> git grep obtain-gcp-service-attachment-for-private-service-connect
docs/en/cloud/security/gcp-private-service-connect.md:TARGET - Use **endpointServiceId** from [Obtain GCP service attachment for Private Service Connect](#obtain-gcp-service-attachment-for-private-service-connect) step
docs/en/cloud/security/gcp-private-service-connect.md:DNS_RECORD - use **privateDnsHostname** from [Obtain GCP service attachment for Private Service Connect](#obtain-gcp-service-attachment-for-private-service-connect) step
docs/en/cloud/security/gcp-private-service-connect.md:DNS_NAME - Use **privateDnsHostname** from [Obtain GCP service attachment for Private Service Connect](#obtain-gcp-service-attachment-for-private-service-connect) step
docs/en/cloud/security/gcp-private-service-connect.md:DNS_RECORD - Use **privateDnsHostname** from [Obtain GCP service attachment for Private Service Connect](#obtain-gcp-service-attachment-for-private-service-connect) step
docs/en/cloud/security/gcp-private-service-connect.md:Each instance with configured Private Service Connect filters has two endpoints: public and private. In order to connect using Private Service Connect, you need to use a private endpoint, see use **endpointServiceId** from [Obtain GCP service attachment for Private Service Connect](#obtain-gcp-service-attachment-for-private-service-connect) step
docs/en/cloud/security/gcp-private-service-connect.md:DNS_NAME - Use **privateDnsHostname** from [Obtain GCP service attachment for Private Service Connect](#obtain-gcp-service-attachment-for-private-service-connect) step
docs/en/cloud/security/gcp-private-service-connect.md:DNS_NAME - Use **privateDnsHostname** from [Obtain GCP service attachment for Private Service Connect](#obtain-gcp-service-attachment-for-private-service-connect) step

I think, other broken anchors could be found similarly.

@DamianMaslanka5
Copy link
Contributor

@Blargian, Docs check job currently fails only for new errors, you can see new errors only on github - https://github.com/ClickHouse/ClickHouse/actions/runs/12680270531/job/35341887430?pr=74277

INFO:root:new error: hash does not exist --- zh/sql-reference/functions/string-search-functions.html --> #hassubsequence
INFO:root:New htmltest errors found

@Blargian Blargian added this pull request to the merge queue Jan 9, 2025
Merged via the queue into ClickHouse:master with commit c0645e2 Jan 9, 2025
19 checks passed
@Blargian Blargian deleted the fix_existing_hash_errors branch January 9, 2025 13:01
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-documentation Documentation PRs for the specific code PR pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants