-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix existing broken hashes on main-repo which cause htmltest to fail #74277
fix existing broken hashes on main-repo which cause htmltest to fail #74277
Conversation
@@ -1961,8 +1961,6 @@ Note we sort by code contributions. Surprisingly high % for all our largest cont | |||
|
|||
To compute this by author is trivial, | |||
|
|||
[play](#U0VMRUNUCiAgICBhdXRob3IsCiAgICBjb3VudElmKGxpbmVfdHlwZSA9ICdDb2RlJykgQVMgY29kZV9saW5lcywKICAgIGNvdW50SWYoKGxpbmVfdHlwZSA9ICdDb21tZW50JykgT1IgKGxpbmVfdHlwZSA9ICdQdW5jdCcpKSBBUyBjb21tZW50cywKICAgIGNvZGVfbGluZXMgLyAoY29tbWVudHMgKyBjb2RlX2xpbmVzKSBBUyByYXRpb19jb2RlLAogICAgdG9TdGFydE9mV2Vlayh0aW1lKSBBUyB3ZWVrCkZST00gZ2l0X2NsaWNraG91c2UubGluZV9jaGFuZ2VzCkdST1VQIEJZCiAgICB0aW1lLAogICAgYXV0aG9yCk9SREVSIEJZCiAgICBhdXRob3IgQVNDLAogICAgdGltZSBBU0MKTElNSVQgMTA=) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will add this back after ClickHouse/sql.clickhouse.com#9
This is an automated comment for commit b58b1ac with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page |
@DamianMaslanka5 @Felixoid could we revert the changes in #73705 ? I see there is a note in docs_check.py to remove some code once all the broken hashes are fixed. I believe all are fixed now, and it's now failing on hashes which I cannot even find in the code. |
I'd suggest fixing them. In this case, we need to search in https://github.com/ClickHouse/clickhouse-docs/, and there are the anchors we need to fix:
I think, other broken anchors could be found similarly. |
@Blargian, Docs check job currently fails only for new errors, you can see new errors only on github - https://github.com/ClickHouse/ClickHouse/actions/runs/12680270531/job/35341887430?pr=74277
|
docs/en/sql-reference/aggregate-functions/reference/quantileexactweighted.md
Outdated
Show resolved
Hide resolved
docs/en/sql-reference/aggregate-functions/reference/quantiletdigest.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Damian Maślanka <[email protected]>
Co-authored-by: Damian Maślanka <[email protected]>
…ix_existing_hash_errors
Fixes existing broken hashes which are detected by htmltest. See here.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing)
All builds in Builds_1 and Builds_2 stages are always mandatory
and will run independently of the checks below: