Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/select-option #493

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Harshvardhan1012
Copy link

@Harshvardhan1012 Harshvardhan1012 commented Oct 27, 2024

fixed label not showing when value is selected by user
Issue #490

Copy link

vercel bot commented Oct 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
click-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2024 8:25am

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2024

CLA assistant check
All committers have signed the CLA.

@@ -285,6 +285,9 @@ export const InternalSelect = ({
);

const optionContextValue = useMemo(() => {
if (selectedValues[0]?.startsWith("\n")) {
selectedValues.length = 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way of implementation is incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants