Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to fix IE 11 compatibility #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Bluesmile82
Copy link
Contributor

The following changes were needed to fix IE compatibility:

  • Include fetch polyfill: https://github.com/whatwg/fetch
  • Use babel-polyfill in every entry in webpack as the first element of an array
  • Query string version lowered to 5.0.0 (version 6 is only for modern browsers)

package.json Outdated
@@ -19,7 +19,7 @@
"foundation-sites": "6.4.3",
"history": "4.7.2",
"lodash-es": "4.17.4",
"query-string": "6.0.0",
"query-string": "5.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried a new library to do the same in Half-Earth and seems to work better: https://github.com/ljharb/qs as it also supports nested properties parsing. So I think worth it to update it here.

@Bluesmile82
Copy link
Contributor Author

Thanks for the tip. Ready again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants