Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct .depth and adds specs #435

Merged
merged 1 commit into from
Jan 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/closure_tree/model.rb
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def leaves
end

def depth
ancestor_hierarchies.size
ancestor_hierarchies.size - 1
end

alias_method :level, :depth
Expand Down
59 changes: 59 additions & 0 deletions test/support/tag_examples.rb
Original file line number Diff line number Diff line change
Expand Up @@ -859,6 +859,65 @@ def assert_parent_and_children
assert_equal(graph, dot)
end
end

describe '.depth' do
it 'should render for an empty scope' do
@tag_class.find_or_create_by_path(%w[a b1 c1])
@tag_class.find_or_create_by_path(%w[a b2 c2])
@tag_class.find_or_create_by_path(%w[a b2 c3])
a, b1, b2, c1, c2, c3 = %w[a b1 b2 c1 c2 c3].map { |ea| @tag_class.where(name: ea).first.id }
dot = @tag_class.roots.first.to_dot_digraph

graph = <<~DOT
digraph G {
"#{a}" [label="a"]
"#{a}" -> "#{b1}"
"#{b1}" [label="b1"]
"#{a}" -> "#{b2}"
"#{b2}" [label="b2"]
"#{b1}" -> "#{c1}"
"#{c1}" [label="c1"]
"#{b2}" -> "#{c2}"
"#{c2}" [label="c2"]
"#{b2}" -> "#{c3}"
"#{c3}" [label="c3"]
}
DOT

assert_equal(graph, dot)
end
end

describe '.depth' do
before do
@d1 = @tag_class.find_or_create_by_path %w[a b c1 d1]
@c1 = @d1.parent
@b = @c1.parent
@a = @b.parent
@a2 = @tag_class.create(name: 'a2')
@b2 = @tag_class.find_or_create_by_path %w[a b2]
@c3 = @tag_class.find_or_create_by_path %w[a3 b3 c3]
@b3 = @c3.parent
@a3 = @b3.parent


end

it 'should return 0 for root' do
assert_equal 0, @a.depth
assert_equal 0, @a2.depth
assert_equal 0, @a3.depth
end

it 'should return correct depth for nodes' do
assert_equal 1, @b.depth
assert_equal 2, @c1.depth
assert_equal 3, @d1.depth
assert_equal 1, @b2.depth
assert_equal 1, @b3.depth
assert_equal 2, @c3.depth
end
end
end
end
end
Loading