Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeactivateHolder and TransferHook out of memory test #17

Draft
wants to merge 19 commits into
base: feature/prd-3895
Choose a base branch
from

Conversation

makarychev
Copy link
Contributor

@makarychev makarychev commented Jul 6, 2024

  1. Add Deactivate Holder instruction
  2. Add validation inside transfer hook if holder is active https://github.com/CoMakery/solana-security-token/pull/17/files#diff-eec568a975abea7913480af31257f78825863e05abbc1025ae8517694d946ab9R25
  3. Add 2 accounts holder_from and holder_to into execute hook instruction https://github.com/CoMakery/solana-security-token/pull/17/files#diff-bde3bede039904e73859dcae39d6e158afa1aeb70d3ed9a07a4185caea065ee8R76
  4. Update tests and implementation that holder is linked by Id not Pubkey in order to be able to derive holder inside the transfer hook execute
  5. Add sdk methods to build and execute transfer with hook inside cancel_timelock in order to be able to check all steps inside it
  6. Add heap allocation method to cancel_timelock to test heap size (After investigation and tests I have found that on last transfer 11 kb of heap is left. If I remove 1 transfer it adds 16 kb on heap.)

@makarychev makarychev force-pushed the feature/prd-3895 branch 2 times, most recently from 930769d to 38c5a69 Compare July 12, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant