add sigma_R to classy (WIP) #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice to add unit test analogue of test_CAMB_sigma_R to check it works with the same syntax (and gives same result!) |
|
Agreed! Will do so at my earliest convenience. |
|
@timothydmorton ping for test? |
19 tasks
|
Done in #222, with a slightly different syntax (using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to open this to get feedback; haven't checked if this matches the expected format of
sigma_Rfrom CAMB. I also tried to mimic how this was done on the CAMB side, and I don't understand much of it, but this does seem to successfully give back the sigma computed by classy. Let me know if you have suggestions!