Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO Date typed interface #66

Merged
merged 6 commits into from
Jan 30, 2025
Merged

ISO Date typed interface #66

merged 6 commits into from
Jan 30, 2025

Conversation

janekamata
Copy link
Contributor

ℹ️ Issue

Closes #52

📝 Description

Created a typed interface for dates in ISO 8601 format (either YYYY-MM-DD or YYYY-MM-DDTHH:mm:ss.sssZ

Briefly list the changes made to the code:

  1. Global interface Date toISOString override and date.ts file export type TDateISO
  2. Basic tests for date toISOString functionality

✔️ Verification

Tests in date.test.ts

🏕️ (Optional) Future Work / Notes

Could add format without milliseconds but default Date() has milliseconds I believe

@janekamata janekamata self-assigned this Jan 29, 2025
@janekamata
Copy link
Contributor Author

Resources/inspo
https://dev.to/pffigueiredo/fixing-typescript-dates-3fjf
https://gist.github.com/MrChocolatine/367fb2a35d02f6175cc8ccb3d3a20054

@janekamata janekamata mentioned this pull request Jan 29, 2025
Closed
Ryaken-Nakamoto
Ryaken-Nakamoto approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@Ryaken-Nakamoto Ryaken-Nakamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@janekamata janekamata merged commit fa05bd1 into main Jan 30, 2025
1 check passed
@jarenadams21 jarenadams21 mentioned this pull request Feb 12, 2025
Open
janekamata added a commit that referenced this pull request Feb 16, 2025
@janekamata
Squashed commit of the following:
e99cfe6 
commit 725946d
Author: Ryaken Nakamoto <[email protected]>
Date:   Wed Feb 12 09:11:12 2025 -0500

    Connecting Front-End to DynamoDB Grant Data (#72)

    * created satchel store for all grants fetched from the backend to display in grantlist

commit fa05bd1
Author: Jane Kamata <[email protected]>
Date:   Wed Jan 29 19:02:58 2025 -0500

    ISO Date typed interface (#66)

    * Added navigation controls from account settings to grant list; changed dashboard to account

    * [JAN-1] Notifications base layer wrap-up

    * [JAN-11] Add navigation controls to go from the "dashboard" < -- > grant list

    * [JAN-1] Notifications base layer wrap-up

    * Created typed interface for ISO dates and tested

    ---------

    Co-authored-by: Jaren Adams <[email protected]>

commit a91bc98
Merge: f888c3b b47a86d
Author: prooflesben <[email protected]>
Date:   Wed Jan 29 18:33:48 2025 -0500

    Merge pull request #67 from Code-4-Community/ryaken

    Fixed

commit b47a86d
Author: ryaken-nakamoto <[email protected]>
Date:   Wed Jan 29 18:12:57 2025 -0500

    got rid of dependency

commit 0bbf3b6
Author: Jaren Adams <[email protected]>
Date:   Tue Jan 28 20:37:53 2025 -0500

    code style changes

commit 33b2948
Merge: 5f6d437 f888c3b
Author: Jaren Adams <[email protected]>
Date:   Tue Jan 28 20:27:45 2025 -0500

    pull in recent updates

commit 5f6d437
Author: ryaken-nakamoto <[email protected]>
Date:   Wed Jan 22 20:01:04 2025 -0500

    go away lock

commit 4c858b5
Author: ryaken-nakamoto <[email protected]>
Date:   Wed Jan 22 19:58:46 2025 -0500

    cleared node modules in frontend

commit 53c37d0
Author: ryaken-nakamoto <[email protected]>
Date:   Wed Jan 22 19:49:30 2025 -0500

    fixed gitignore

commit 06fbf94
Author: ryaken-nakamoto <[email protected]>
Date:   Wed Jan 22 19:47:59 2025 -0500

    fix crypto error

commit a1c29aa
Author: ryaken-nakamoto <[email protected]>
Date:   Wed Jan 22 19:34:55 2025 -0500

    try4

commit bf1ed9a
Author: ryaken-nakamoto <[email protected]>
Date:   Wed Jan 22 19:29:16 2025 -0500

    try3

commit 48c1832
Author: ryaken-nakamoto <[email protected]>
Date:   Wed Jan 22 19:18:57 2025 -0500

    try2

commit 9b39987
Author: ryaken-nakamoto <[email protected]>
Date:   Wed Jan 22 18:58:54 2025 -0500

    json change

commit 52b5fcb
Author: ryaken-nakamoto <[email protected]>
Date:   Tue Jan 21 18:38:32 2025 -0500

    added save functionality status

commit c291cef
Author: ryaken-nakamoto <[email protected]>
Date:   Wed Jan 15 18:52:36 2025 -0500

    cleaning up App.css and index.css, margin removed on edges when grant is expanded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryaken-Nakamoto Ryaken-Nakamoto Ryaken-Nakamoto approved these changes

Assignees

@janekamata janekamata

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JAN-13] Switch Date to Proper "Date Time" for Sorting as a Number
2 participants
@janekamata @Ryaken-Nakamoto