Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route Updates and 'Volunteer' page Links to 'My Adopted Green Infrastructure' page #21

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

jarenadams21
Copy link

ℹ️ Issue
Closes [internal ticket 2 for demo day]

📝 Description
Write a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.

Briefly list the changes made to the code:

  1. Added a Link wrapper around the 'My Adopted GI' on the Volunteer page.
  2. Updated main.tsx to accommodate the /volunteer and /volunteer/my-adopted-gi routes.

✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.

Tested multiple times to ensure the routes worked as expected, going back and forth between main and the /volunteer/my-adopted-gi levels.

Provide screenshots of any new components, styling changes, or pages.

N/A

🏕️ (Optional) Future Work / Notes

  1. Directory shortcuts using '.'s and '/'s for nested routes is helpful. Allows deep nesting without relying on potentially changing route name(s).
  2. Reminder --> If you are already under a nested route, say /volunteer, using under that page will route to /volunteer/my-adopted-gi. (No starting slash will maintain your current pathing, but a starting slash (/) will be treated as absolute.

Copy link

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hams7504 hams7504 merged commit 0519210 into main Apr 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants