Add support for notification class.

Closes #24. Minor cleanups in code and readme file. Signed-off-by: Łukasz Dywicki <[email protected]>
Code-House · Oct 30, 2023 · 406e048 · 406e048
1 parent c1e5c3a
commit 406e048
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -72,12 +72,20 @@ As of 1.2.x there is support for additional object types, however they are consi
 * largeAnalogValue
 * octetstringValue
 * timeValue
+* dateValue
 * integerValue
 * positiveIntegerValue
 * datetimePatternValue
 * timePatternValue
 * datePatternValue
 * accumulator
+* device
+* trendLog
+* file
+
+As of 1.3.x version there is support for following object types:
+
+* notificationClass
 
 Most of them is still commendable and supports access through `present value` property, but some of them bring additional properties
 which are not visible through wrapper APIs.
@@ -87,7 +95,7 @@ If you are interested in adding other types of objects to API feel free to submi
 Each property of type enlisted above can be read and attempted to set via `client.getPropertyValue` and `client.setPropertyValue` method calls.
 There are two variants of set/get property methods - with and without converter argument.
 If you know type of property then you can convert it upfront to bacnet4j structure.
-By default library will try to guess, however in most of cases it will fail.
+By default, library will try to guess, however in most of the cases it may fail.
 
 ### How to build
 
@@ -99,4 +107,5 @@ To build project you need:
 
 * [Mango Automation BACnet4J](https://github.com/MangoAutomation/BACnet4J) - this is currently maintained version of BACnet4J used in this project.
 * [Bacnet4J site](http://bacnet.sourceforge.net)
-* [BACNet-openHAB-binding](https://github.com/openhab/org.openhab.binding.bacnet) - openhab binding which uses this project.
+* [ConnectorIO Addons](https://github.com/connectorio/connectorio-addons) - consist a bacnet binding which integrates bacnet networks (mstp and ip) with openhab 2.x and above 
+* [BACNet-openHAB-binding](https://github.com/openhab/org.openhab.binding.bacnet) - openhab 1.x binding which uses this project.
diff --git a/api/src/main/java/org/code_house/bacnet4j/wrapper/api/Type.java b/api/src/main/java/org/code_house/bacnet4j/wrapper/api/Type.java
@@ -38,6 +38,8 @@ public enum Type {
     MULTISTATE_OUTPUT("multiStateOutput", ObjectType.multiStateOutput),
     MULTISTATE_VALUE("multiStateValue", ObjectType.multiStateValue),
 
+    NOTIFICATION_CLASS("notificationClass", ObjectType.notificationClass),
+
     CALENDAR ("calendar", ObjectType.calendar),
     PULSE_CONVETHING_RTER("pulseCoverter", ObjectType.pulseConverter),
 
@@ -57,7 +59,7 @@ public enum Type {
 
     DEVICE ("device", ObjectType.device),
     TREND_LOG ("trendLog", ObjectType.trendLog),
-    FILE ("trendLog", ObjectType.file);
+    FILE ("file", ObjectType.file);
 
 
     private final String name;