Manual input test

[VoldemLive]

Manual Input Blood Test Results Feature

Features

1. Create new blood test with:

   • Biomarker selection
   • Value input
   • Automatic reference range assignment
   • Automatic unit assignment
   • Optional notes
   • Patient selection (for users with full access)

2. Validation rules:

   • Value must be non-negative
   • Value must be numeric
   • Biomarker must be selected
   • Reference range must exist
   • Unit must be present

3. UI Features:

   • Dynamic reference range display
   • Error messages display
   • Success messages after creation
   • Form field validation indicators

Test Plan

1. Unit Tests:

   • Model validations for LabTest
   • Associations between models
   • Value validation (negative, zero, positive, non-numeric)
   • Required field validations

2. Integration Tests:

   • Successful blood test creation
   • Error handling for invalid inputs
   • Form submission with all required fields
   • JavaScript-dependent functionality

3. Feature Tests:

   • Complete form submission workflow
   • Dynamic field updates
   • Error message display
   • Success message display
   • Patient selection for authorized users

4. Edge Cases:

   • Boundary values for reference ranges
   • Special characters in inputs
   • Zero and negative values
   • Missing required fields
   • Invalid biomarker selections

   ---

TEST RESULTS:

...Capybara starting Puma...

• Version 6.4.3, codename: The Eagle of Durango
• Min threads: 0, max threads: 4
• Listening on http://127.0.0.1:64570
  .....................

Finished in 5.04 seconds (files took 1.7 seconds to load)
24 examples, 0 failures

[aksafan]

Well done with the task and tests!

Please look at comments, especially about "Blood" test naming and SOLID.
Also, please target develop as a branch for all feature requests.

[aksafan]

Well done in LabTest controller.
Almost ready for being approved.

Please make sure to answer and cover all comments left.

[VoldemLive]

When showing validation errors, there is an inconsistent message for the value field and there is a duplication of error messages on a page:

removed additional error label

[aksafan]

When showing validation errors, there is an inconsistent message for the value field and there is a duplication of error messages on a page:

removed additional error label

@VoldemLive Well done!

So only set_user issue left.

[VoldemLive]

When showing validation errors, there is an inconsistent message for the value field and there is a duplication of error messages on a page:

removed additional error label

@VoldemLive Well done!

So only set_user issue left.

got it and fixed.

[aksafan]

When showing validation errors, there is an inconsistent message for the value field and there is a duplication of error messages on a page:

removed additional error label

@VoldemLive Well done!
So only set_user issue left.

got it and fixed.

@VoldemLive where?
It still in code:

The error appears when you haven't set a user properly here.
This happens cause here you have nil in params[:user_id] and you can't call nil.present?.
And this happens cause there is no user_id in params, there is only lab_test in params and user_id is inside that lab_test:

So that user_id is nested in lab_test. You need to handle this.

You can just extract it from lab_test_params.

[VoldemLive]

The error appears when you haven't set a user properly here.
This happens cause here you have nil in params[:user_id] and you can't call nil.present?.
And this happens cause there is no user_id in params, there is only lab_test in params and user_id is inside that lab_test:

you are right, rewrited:
def set_user if current_user.full_access_roles_can? User.find(lab_test_params[:user_id]) else current_user end end

in a few sec will push fixes

[aksafan]

def set_user if current_user.full_access_roles_can? User.find(lab_test_params[:user_id]) else current_user end end

@VoldemLive Great!

One question: what if there is no user_id in lab_test_params or lab_test_params[:user_id] is empty?
I assume, that check won't work.

What do you think about this?

  def set_user
    if current_user.full_access_roles_can? && lab_test_params[:user_id].present?
      User.find(lab_test_params[:user_id])
    else
      current_user
    end
  end

This will cover both of those cases.

[VoldemLive]

One question: what if there is no user_id in lab_test_params or lab_test_params[:user_id] is empty? I assume, that check won't work.

What do you think about this?

hmm ... we still need to check it in "if" before, or we will crach the app

[aksafan]

One question: what if there is no user_id in lab_test_params or lab_test_params[:user_id] is empty? I assume, that check won't work.
What do you think about this?

hmm ... we still need to check it in "if" before, or we will crach the app

Exactly!

[aksafan]

@VoldemLive Well done with all of fixes and changes!

Huge gratz on merging your first pull request!
I'm proud of your stamina and agility!

[VoldemLive]

@VoldemLive Well done with all of fixes and changes!

Huge gratz on merging your first pull request! I'm proud of your stamina and agility!

Thank you Anton for the persistence and patience in helping beginners. I need to drink ))))))