Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

please add banner style updates V2 #507

Merged
merged 5 commits into from
Dec 21, 2021
Merged

please add banner style updates V2 #507

merged 5 commits into from
Dec 21, 2021

Conversation

AlphaLaryBah
Copy link
Contributor

Version two. Thank you.

@netlify
Copy link

netlify bot commented Dec 16, 2021 •
edited
Loading

👷 Deploy request for upswyng accepted.

🔨 Explore the source changes: 2306791

🔍 Inspect the deploy log: https://app.netlify.com/sites/upswyng/deploys/61c12a65e159c600083af9ac

@jacobvenable
Copy link
Member

Hey, thanks for contributing! This is a change from your last PR, correct?
#506

If so, go ahead and close that one with a comment pointing to this update. Thanks!

jacobvenable
jacobvenable reviewed Dec 19, 2021
View reviewed changes
Copy link
Member

@jacobvenable jacobvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Alpha 👋 Thanks for the updates! I'm seeing that the icon and the text are now stacked, but we do want those to remain side-by-side.

example of stacked banner

I've added some comments throughout that I think will achieve the layout we're looking for. One final item I couldn't comment on is adding an edge="start" prop to the BackButton's <IconButton/>. This will have the left side of the icon button properly align with the rest of the content on the page.

Thanks again!

jacobvenable
jacobvenable approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@jacobvenable jacobvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for all the updates 🎉

@jacobvenable jacobvenable merged commit de376d3 into CodeForBoulder:main Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobvenable jacobvenable jacobvenable approved these changes

@jollyjerr jollyjerr Awaiting requested review from jollyjerr jollyjerr is a code owner

@rhinodavid rhinodavid Awaiting requested review from rhinodavid rhinodavid is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlphaLaryBah @jacobvenable