Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heading line spacing and padding #1072

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

ngducanh126
Copy link

@ngducanh126 ngducanh126 commented Jan 8, 2025

Fix heading line spacing and padding for issue #1021

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vacant-lots-proj ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 5:42pm

@CodeWritingCow
Copy link
Collaborator

Headings look correct

Before
Screen Shot 2025-01-10 at 1 48 35 AM

After
Screen Shot 2025-01-10 at 1 48 53 AM

Before
Screen Shot 2025-01-10 at 1 50 10 AM

After
Screen Shot 2025-01-10 at 1 50 20 AM

@CodeWritingCow
Copy link
Collaborator

However, the space between h1 and h2 doesn't look much different. Same with the space between h2 and the body.

Before
Screen Shot 2025-01-10 at 1 53 17 AM

After
Screen Shot 2025-01-10 at 1 53 28 AM

Copy link
Collaborator

@CodeWritingCow CodeWritingCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngducanh126 can you address my feedback about the space between h1 and h2, and also between h2 and body? Thank you.

Copy link

This PR has been marked as stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants