-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codeception 5.0 #82
Codeception 5.0 #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me but header is misleading.
It says 5.0 support but I see new feature "pixel ratio" added.
Could you update Changelog instead?
"description": "Visual regression tests for Codeception", | ||
"name": "nixdrey/wbisualception", | ||
"description": "Visual regression tests for Codeception (fork from https://github.com/Codeception/VisualCeption)", | ||
"homepage": "https://github.com/nixdrey/VisualCeption", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please revert this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I accidentally create this pull request
|
||
**Example** | ||
## Pixel ratio support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good but please keep also the original docs
No description provided.