Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeception 5.0 #82

Closed
wants to merge 12 commits into from
Closed

Conversation

nixdrey
Copy link

@nixdrey nixdrey commented Apr 15, 2024

No description provided.

Copy link
Member

@DavertMik DavertMik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me but header is misleading.

It says 5.0 support but I see new feature "pixel ratio" added.

Could you update Changelog instead?

"description": "Visual regression tests for Codeception",
"name": "nixdrey/wbisualception",
"description": "Visual regression tests for Codeception (fork from https://github.com/Codeception/VisualCeption)",
"homepage": "https://github.com/nixdrey/VisualCeption",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please revert this change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I accidentally create this pull request


**Example**
## Pixel ratio support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good but please keep also the original docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants