Avoid double evaluation

Codeception · Mar 14, 2022 · 214fe0c · 214fe0c
1 parent 486663a
commit 214fe0c
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/Codeception/Module/Filesystem.php b/src/Codeception/Module/Filesystem.php
@@ -79,10 +79,11 @@ protected function absolutizePath(string $path): string
      */
     public function openFile(string $filename): void
     {
-        if (!file_exists($this->absolutizePath($filename))) {
+        $absolutePath = $this->absolutizePath($filename);
+        if (!file_exists($absolutePath)) {
             TestCase::fail('file not found');
         }
-        $this->file = file_get_contents($this->absolutizePath($filename));
+        $this->file = file_get_contents($absolutePath);
         $this->filePath = $filename;
     }
 
@@ -96,11 +97,12 @@ public function openFile(string $filename): void
      */
     public function deleteFile(string $filename): void
     {
-        if (!file_exists($this->absolutizePath($filename))) {
+        $absolutePath = $this->absolutizePath($filename);
+        if (!file_exists($absolutePath)) {
             TestCase::fail('file not found');
         }
 
-        unlink($this->absolutizePath($filename));
+        unlink($absolutePath);
     }
 
     /**