Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compatibility issue with WP Optimize #406

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Conversation

girishpanchal30
Copy link
Contributor

Close #404

@girishpanchal30 girishpanchal30 linked an issue Oct 25, 2023 that may be closed by this pull request
@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 25, 2023

Plugin build for c2f8347 is ready 🛎️!

Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember, the pages were kept private to avoid non-admins seeing them when they were published: 73707a4

It will add an issue where if you import a template and don't publish it, the homepage will start redirect and page won't load.

The same won't with the existing version.

@girishpanchal30
Copy link
Contributor Author

@HardeepAsrani Thank you for checking! I've got the solution, can you please check with the latest commit when you have a moment?

@irinelenache
Copy link

@girishpanchal30 Tested and everything's fine on my end 👍

@vytisbulkevicius
Copy link
Contributor

@girishpanchal30, can you check this conflict? Thanks!

@girishpanchal30
Copy link
Contributor Author

@vytisbulkevicius Fixed

@vytisbulkevicius vytisbulkevicius merged commit 1384223 into development Dec 21, 2023
3 of 4 checks passed
@vytisbulkevicius vytisbulkevicius deleted the bugfix/404 branch December 21, 2023 17:17
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.6.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict with WP-Optimize
5 participants