-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add redbot-setup restore
cli command for restoring instance from backup
#3681
base: V3/develop
Are you sure you want to change the base?
Conversation
This PR is ready for review. Or at least as ready as it can be - restoring cogs is still far from perfect as it requires running I decided to finish it up anyway and we can decide later in the org whether we want to freeze this until appropriate rewriting is done or if the feature is good enough to ship it before that's done. |
297882c
to
b513c32
Compare
ad7a33d
to
263767e
Compare
263767e
to
2da1056
Compare
Type
Description of the changes
Fixes #2947
I added progress bars to indicate to the user that the command does something but they're surely not the most accurate progress bars - progress bar for (un)packing archives are based on file amount, not on file size and progress bar for downloading repos is based on repo amount. I'm open to improving it but I think it still serves its purpose even if it's not very linear.
Note:
Restoring cogs is still far from perfect as it requires running
[p]cog update
after the offline restoring process so that the previously installed cogs get reinstalled (it's totally possible to reinstall cogs offline but it would require rewriting more than I currently have time for).I decided to finish it up anyway and we can decide later in the org whether we want to freeze this until appropriate rewriting is done or if the feature is good enough to ship it before that's done.
Other minor fixes/enhancements:
redbot-setup
andredbot --edit
no longer stops whole process and instead asks for the path againredbot-setup delete
no longer tries to connect to database if user doesn't want to delete instance's data--debug
is now a flag inredbot-setup
to be consistent withredbot