Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redbot-setup restore cli command for restoring instance from backup #3681

Draft
wants to merge 13 commits into
base: V3/develop
Choose a base branch
from

Conversation

Jackenmen
Copy link
Member

@Jackenmen Jackenmen commented Mar 22, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Fixes #2947

I added progress bars to indicate to the user that the command does something but they're surely not the most accurate progress bars - progress bar for (un)packing archives are based on file amount, not on file size and progress bar for downloading repos is based on repo amount. I'm open to improving it but I think it still serves its purpose even if it's not very linear.

Note:

Restoring cogs is still far from perfect as it requires running [p]cog update after the offline restoring process so that the previously installed cogs get reinstalled (it's totally possible to reinstall cogs offline but it would require rewriting more than I currently have time for).

I decided to finish it up anyway and we can decide later in the org whether we want to freeze this until appropriate rewriting is done or if the feature is good enough to ship it before that's done.

Other minor fixes/enhancements:

  • backup can now have a version of its own if we would need to change something about its format later
  • passing wrong data path to redbot-setup and redbot --edit no longer stops whole process and instead asks for the path again
  • passing an already used name for instance and deciding not to replace it no longer stops whole process and instead asks for the instance name again
  • redbot-setup delete no longer tries to connect to database if user doesn't want to delete instance's data
  • --debug is now a flag in redbot-setup to be consistent with redbot

@Jackenmen Jackenmen added Type: Feature New feature or request. Work In Progress Category: Cogs - Downloader This is related to the Downloader cog. and removed Work In Progress labels Mar 22, 2020
@Jackenmen Jackenmen marked this pull request as ready for review March 27, 2020 15:01
@Jackenmen
Copy link
Member Author

Jackenmen commented Mar 27, 2020

This PR is ready for review. Or at least as ready as it can be - restoring cogs is still far from perfect as it requires running [p]cog update after the offline restoring process so that the previously installed cogs get reinstalled (it's totally possible to reinstall cogs offline but it would require rewriting more than I currently have time for).

I decided to finish it up anyway and we can decide later in the org whether we want to freeze this until appropriate rewriting is done or if the feature is good enough to ship it before that's done.

@Jackenmen Jackenmen added this to the 3.3.4 milestone Mar 28, 2020
@Jackenmen Jackenmen force-pushed the V3/restore_command branch from 297882c to b513c32 Compare March 31, 2020 23:58
@Jackenmen Jackenmen added the Blocked By: Other PR Blocked by another PR. label Mar 31, 2020
@Jackenmen Jackenmen modified the milestones: 3.3.4, 3.3.5, 3.3.6 Apr 5, 2020
@Jackenmen Jackenmen force-pushed the V3/restore_command branch from ad7a33d to 263767e Compare April 20, 2020 18:17
@Jackenmen Jackenmen force-pushed the V3/restore_command branch from 263767e to 2da1056 Compare April 27, 2020 00:03
@Jackenmen Jackenmen removed the Blocked By: Other PR Blocked by another PR. label Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Downloader This is related to the Downloader cog. Type: Feature New feature or request.
Projects
None yet
2 participants