-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The big intents checklist. #4574
Draft
Kowlin
wants to merge
12
commits into
Cog-Creators:V3/develop
Choose a base branch
from
Kowlin:pr/intents/part1
base: V3/develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+88
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto pr/intents/part1
Hbutlercapone
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category: Cogs - CustomCommands
This is related to the CustomCommands cog.
Category: Cogs - Economy
This is related to the Economy cog.
Category: Cogs - Mod
This is related to the Mod cog.
Category: Cogs - Mutes
This is related to the Mutes cog.
Category: Cogs - Permissions
This is related to the Permissions cog.
Category: Cogs - Reports
This is related to the Reports cog.
Category: Cogs - Trivia
This is related to the Trivia cog.
Category: Cogs - Warnings
This is related to the Warnings cog.
Category: Core - API - Bank
This is related to the core Bank API.
Type: Bug
Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Type: Optimisation
Situations where too much time is necessary to complete the task.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes over all member and presence intents to ensure that they don't break horrible on Red. While we normally said that we don't want to rely on fetching members. Discord is sadly forcing our hand here, and for now this is the simplest fix we can do.
Querying however makes this easier to handle in bulk and should be used when possible. One of those instances would be mute.
Gonna keep this as a draft for now as this is a big WIP with still several cogs needing manual checking of code and ensuring everything doesn't horrible break.