[Bank] Add discord.Object support to bank.get_balance

[goettner]

Type

• Bugfix
• Enhancement
• New feature

Description of the changes

As detailed in #4391, much of the Core Bank API functions only accepted discord.Member or discord.User input types for routine functions such as get_balance(). This is problematic, given the unnecessary and possibly sensitive information that is included with a Member or User object. This can be improved by changing the calls' input types to enable passing it a discord.Object instead, in order to prevent sensitive information being unnecessarily acquired.

I also added test cases to tests/cogs/test_economy.py, in order to test the ability of these API calls to function correctly with a discord.Object as input, and the necessary infrastructure in pytest/core.py

[Drapersniper]

You've misunderstood my last statement I think, discord objects only have the .id attributes and not the rest of the other attributes that a user or member has, as such special handling is required here.

The remaining bank apis should also accept the discord.Object input.

[goettner]

Okay, I see. With that in mind then, how do you propose handling situations where other object members are used? Specifically with this block in bank.get_account() in mind:

[Drapersniper]

Okay, I see. With that in mind then, how do you propose handling situations where other object members are used? Specifically with this block in bank.get_account() in mind:

For one discord.Object could only ever replace users and not members, since members have an additional guild attribute. This would mean objects can ever only be used in global banks

For the attribute access, I would personally add placeholders, such as "John doe" for the display name access since that doesn't exist on an Object

[goettner]

For the attribute access, I would personally add placeholders, such as "John doe" for the display name access since that doesn't exist on an Object

Pushed some changes based on your feedback, let me know what you think.

[bobloy]

This line will and should fail error with discord.Object. Even if it were to succeed with Object, get_default_balance below would throw a runtime error