Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit zero-length prefixes in [p]set [server]prefix #6013

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

japandotorg
Copy link
Contributor

Description of the changes

Disallow empty prefixes being a thing.
For example:
image

Have the changes in this PR been tested?

yes
image

@github-actions github-actions bot added the Category: Core - Bot Commands This is related to core commands (Core and CogManagerUI cog classes). label Apr 11, 2023
@Jackenmen
Copy link
Member

Seems like this should also be done to [p]set prefix?

@japandotorg
Copy link
Contributor Author

Seems like this should also be done to [p]set prefix?

yeah, totally forgot about that command

@Kreusada Kreusada changed the title [Core] disallow noprefix being a thing [Core] Prohibit zero-length prefixes Apr 14, 2023
@Kreusada Kreusada added the Type: Feature New feature or request. label Apr 14, 2023
@Kreusada Kreusada self-assigned this May 12, 2023
@Jackenmen Jackenmen changed the title [Core] Prohibit zero-length prefixes Prohibit zero-length prefixes Jun 20, 2023
@Jackenmen Jackenmen changed the title Prohibit zero-length prefixes Prohibit zero-length prefixes in [p]set [server]prefix Jun 20, 2023
@Kreusada Kreusada added this to the 3.5.6 milestone Feb 13, 2024
Copy link
Member

@Kreusada Kreusada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it works well. Thanks for implementing this.

@Kreusada Kreusada merged commit 9dc7462 into Cog-Creators:V3/develop Feb 27, 2024
17 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Feb 27, 2024
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Mar 22, 2024
Dav-Git pushed a commit to Dav-Git/Red-DiscordBot that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Core - Bot Commands This is related to core commands (Core and CogManagerUI cog classes). Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Feature New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants