Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-source supported Java versions in Audio code #6500

Conversation

Jackenmen
Copy link
Member

@Jackenmen Jackenmen commented Dec 28, 2024

Description of the changes

Updated the code so that the supported Java versions are sourced from constants in one place. This refactoring will be helpful when we implement LL jar updates outside the normal release schedule.

Have the changes in this PR been tested?

Yes

Screenshots from testing

image
image
image

@Jackenmen Jackenmen added Type: Enhancement Something meant to enhance existing Red features. Changelog Entry: Skipped Changelog entry for this PR is unnecessary. labels Dec 28, 2024
@Jackenmen Jackenmen added this to the 3.5.15 milestone Dec 28, 2024
@github-actions github-actions bot added the Category: Cogs - Audio This is related to the Audio cog. label Dec 28, 2024
Copy link
Member

@aikaterna aikaterna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
cat-high-five-1762052381

@aikaterna aikaterna merged commit 6bf2a88 into Cog-Creators:V3/develop Jan 26, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Audio This is related to the Audio cog. Changelog Entry: Skipped Changelog entry for this PR is unnecessary. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants