Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore: 🔧 Seperate Business Logic From DeviceTokenRegisterService #210

Merged
merged 13 commits into from
Dec 20, 2024

Conversation

psychology50
Copy link
Member

작업 이유

  • Addressed factors that make TDD challenging.
  • For more details, refer to this blog post.

작업 사항

  • Business rules are now handled by first-class objects that represent domain rules.
  • Service classes now perform integration testing with infrastructure components.

리뷰어가 중점적으로 확인해야 하는 부분

  • Is the separation of business rules and infrastructure appropriate?
  • Are there potential edge cases in how the first-class objects handle domain rules?

발견한 이슈

  • DeviceToken Persistence:
    • Despite being generated within a transaction (Tx), DeviceToken was not persisted unless explicitly created using a create method. Although the issue has been resolved, the root cause is still under investigation.

@psychology50 psychology50 added the refactoring 리팩토링 작업 label Dec 19, 2024
@psychology50 psychology50 self-assigned this Dec 19, 2024
@psychology50 psychology50 merged commit 09336ff into dev Dec 20, 2024
1 check passed
@psychology50 psychology50 deleted the refactor/apply-correct-tdd branch December 20, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring 리팩토링 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant