Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore: ✏️ Add Send Message Headers to the Error Message #212

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Ignore: ✏️ Add Send Message Headers to the Error Message #212

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4afaf67
feat: add default server error handler
psychology50 Dec 31, 2024
04a8d15
feat: add message-id in the error response's header
psychology50 Dec 31, 2024
fc8d5d7
fix: include request message headers in the error message
psychology50 Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 55 additions & 3 deletions ...src/main/java/kr/co/pennyway/socket/common/exception/WebSocketGlobalExceptionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,23 @@
package kr.co.pennyway.socket.common.exception;

import com.fasterxml.jackson.databind.exc.MismatchedInputException;
import kr.co.pennyway.common.exception.GlobalErrorException;
import kr.co.pennyway.common.exception.ReasonCode;
import kr.co.pennyway.common.exception.StatusCode;
import kr.co.pennyway.socket.common.dto.ServerSideMessage;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.springframework.http.converter.HttpMessageNotReadableException;
import org.springframework.messaging.handler.annotation.MessageExceptionHandler;
import org.springframework.messaging.simp.SimpMessagingTemplate;
import org.springframework.messaging.simp.stomp.StompHeaderAccessor;
import org.springframework.web.bind.annotation.ControllerAdvice;
import org.springframework.web.method.annotation.MethodArgumentTypeMismatchException;

import java.security.Principal;

import static kr.co.pennyway.common.exception.ReasonCode.TYPE_MISMATCH_ERROR_IN_REQUEST_BODY;

/**
* 비지니스 예외를 처리하는 전역 핸들러.
*/
Expand All @@ -18,13 +26,57 @@
@RequiredArgsConstructor
public class WebSocketGlobalExceptionHandler {
private static final String ERROR_DESTINATION = "/queue/errors";

private final SimpMessagingTemplate template;

@MessageExceptionHandler(GlobalErrorException.class)
public void handleGlobalErrorException(Principal principal, GlobalErrorException ex) {
ServerSideMessage serverSideMessage = ServerSideMessage.of(ex.causedBy().getCode(), ex.getBaseErrorCode().getExplainError());
public void handleGlobalErrorException(Principal principal, StompHeaderAccessor accessor, GlobalErrorException e) {
ServerSideMessage serverSideMessage = ServerSideMessage.of(e.causedBy().getCode(), e.getBaseErrorCode().getExplainError());
log.warn("handleGlobalErrorException: {}", serverSideMessage);

template.convertAndSendToUser(principal.getName(), ERROR_DESTINATION, serverSideMessage);
sendErrorMessage(principal, serverSideMessage, accessor);
}

@MessageExceptionHandler(MethodArgumentTypeMismatchException.class)
public void handleMethodArgumentTypeMismatchException(Principal principal, StompHeaderAccessor accessor, MethodArgumentTypeMismatchException e) {
String code = String.valueOf(StatusCode.UNPROCESSABLE_CONTENT.getCode() * 10 + TYPE_MISMATCH_ERROR_IN_REQUEST_BODY.getCode());
ServerSideMessage serverSideMessage = ServerSideMessage.of(code, e.getMessage());
log.warn("handleMethodArgumentTypeMismatchException: {}", serverSideMessage);

sendErrorMessage(principal, serverSideMessage, accessor);
}

@MessageExceptionHandler(HttpMessageNotReadableException.class)
public void handleHttpMessageNotReadableException(Principal principal, StompHeaderAccessor accessor, HttpMessageNotReadableException e) {
String code, message;
if (e.getCause() instanceof MismatchedInputException mismatchedInputException) {
code = String.valueOf(StatusCode.UNPROCESSABLE_CONTENT.getCode() * 10 + TYPE_MISMATCH_ERROR_IN_REQUEST_BODY.getCode());
message = mismatchedInputException.getPath().get(0).getFieldName() + " 필드의 값이 유효하지 않습니다.";
} else {
code = String.valueOf(StatusCode.BAD_REQUEST.getCode() * 10 + ReasonCode.MALFORMED_REQUEST_BODY.getCode());
message = e.getMessage();
}

ServerSideMessage serverSideMessage = ServerSideMessage.of(code, message);
log.warn("handleHttpMessageNotReadableException: {}", serverSideMessage);

sendErrorMessage(principal, serverSideMessage, accessor);
}

@MessageExceptionHandler(Exception.class)
public void handleException(Principal principal, StompHeaderAccessor accessor, Exception e) {
ServerSideMessage serverSideMessage = ServerSideMessage.of("5000", e.getMessage());
log.error("handleException: {}", serverSideMessage);

sendErrorMessage(principal, serverSideMessage, accessor);
}

private void sendErrorMessage(Principal principal, ServerSideMessage serverSideMessage, StompHeaderAccessor accessor) {
if (principal == null) {
log.warn("예외 메시지를 반환할 사용자가 없습니다.");
return;
}

template.convertAndSendToUser(principal.getName(), ERROR_DESTINATION, serverSideMessage, accessor.getMessageHeaders());
}
}
Loading