Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore: ✨ Leave Chat Room API #215

Merged
merged 25 commits into from
Jan 8, 2025
Merged

Conversation

psychology50
Copy link
Member

작업 이유

  • Chat members can leave a chat room.
  • However, the chat room master cannot leave if at least one other member remains in the room.

작업 사항

  • Implemented business logic for leaving chat rooms.
  • Added service unit tests.
  • Added service integration tests.

리뷰어가 중점적으로 확인해야 하는 부분

  • None.

발견한 이슈

  • Temporarily disabled the ChatRoomDetailIntegrationTest due to a malfunction:
    • When a ChatMember tries to add itself to the ChatRoom fields after the session is closed, a failed to lazily initialize error occurs
    • While I could use ChatMemberJoinService to address this, it has too many dependencies and does not return the ChatMember entity.
    • I plan to address these issues in the next task.

@psychology50 psychology50 added the enhancement New feature or request label Jan 7, 2025
@psychology50 psychology50 self-assigned this Jan 7, 2025
@psychology50 psychology50 merged commit 389509c into dev Jan 8, 2025
1 check passed
@psychology50 psychology50 deleted the feat/PW-660-exit-chat-room branch January 8, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant