Ignore: π§ Remove Chat Member Id from Leave Chat Room API Spec #230
+15
β18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychology50
added
bug
psychology50
deleted the
fix/delete-chat-member-id-path-in-leave-chatroom
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
μμ μ΄μ
ππββοΈπ
μμ μ¬ν
The
chat_member_idfield is unnecessary in the Leave Chat Room API, as it does not align with the principles of Domain-Driven Design (DDD). Instead, the required data can be derived from the authenticated user's session or context.So remove it.
리뷰μ΄κ° μ€μ μ μΌλ‘ νμΈν΄μΌ νλ λΆλΆ
λ°κ²¬ν μ΄μ