Skip to content

Commit

Permalink
[backup] Don't display false-positive warn
Browse files Browse the repository at this point in the history
Summary:
Described in [[ https://linear.app/comm/issue/ENG-10179/investigate-why-backup-wasnt-removed-during-keyserver-owner-logout#comment-73457631 | ENG-10179 ]].
The warning is false-positive when limit is set because `last_evaluated_key` is present in that case.

Test Plan: Tested on staging, real world scenario we were encountering seems not to be reproducible on localstack.

Reviewers: kamil, tomek

Reviewed By: kamil

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D14372
  • Loading branch information
barthap committed Feb 17, 2025
1 parent 905ba74 commit 8f84e77
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion services/backup/src/database/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ impl DatabaseClient {
Error::AwsSdk(e.into())
})?;

if response.last_evaluated_key().is_some() {
if response.last_evaluated_key().is_some() && limit.is_none() {
// In the intial version of the backup service this function will be run
// for every new backup (each user only has one backup), so this shouldn't
// happen
Expand Down

0 comments on commit 8f84e77

Please sign in to comment.