[native] Update updateRolesAndPermissions to only handle `LegacyRaw…

…ThreadInfos`

Summary:
Similar to what we did in D10283, we're "lying" to `flow` and saying that `updatedRolesAndPermissions` (which we also rename `legacyUpdateRolesAndPermissions`) accepts `RawThreadInfos` instead of just `LegacyRawThreadInfos`. However, we call `assertAllThreadInfosAreLegacy` right at the start of `legacyUpdateRolesAndPermissions` to ensure that only `LegacyRawThreadInfos` are passed to this function.

It could be argued that this is worse than D10283, because it's unlikely that we'd want to run the `convertThreadStoreThreadInfosToNewIDSchema` migration again, whereas it's VERY likely that we'll want to run `updateRolesAndPermissions` in the future. I will introduce a new version of `updateRolesAndPermissions` that'll handle `MinimallyEncodedRawThreadInfos` (by going through and converting all to `LegacyRawThreadInfos` which is what the logic in this migration requires since that's what eg `getRolePermissionBlobs` and `makePermissionsBlob` deal with. I'll put that up as a followup diff in this stack (probably before landing anything).

However, as of this diff we're now at 0 `flow` issues in `native`/`web`/`keyserver`/`lib`.

---

Depends on D10283

Test Plan: CI, `flow`, etc. I think in the future it would be nice to have unit tests for migrations.

Reviewers: ashoat, ginsu, tomek, rohan

Reviewed By: ashoat

Differential Revision: https://phab.comm.dev/D10284

native/redux/update-roles-and-permissions.js → native/redux/legacy-update-roles-and-permissions.js

@@ -6,11 +6,13 @@ import {
   makePermissionsBlob,
   makePermissionsForChildrenBlob,
 } from 'lib/permissions/thread-permissions.js';
+import { assertAllThreadInfosAreLegacy } from 'lib/shared/thread-utils.js';
 import type { ThreadPermissionsBlob } from 'lib/types/thread-permission-types.js';
 import type {
   LegacyRawThreadInfo,
   ThreadStoreThreadInfos,
   LegacyMemberInfo,
+  RawThreadInfos,
 } from 'lib/types/thread-types.js';
 import { values } from 'lib/utils/objects.js';
 
@@ -48,10 +50,13 @@ type MemberToThreadPermissionsFromParent = {
   +[member: string]: ?ThreadPermissionsBlob,
 };
 
-function updateRolesAndPermissions(
-  threadStoreInfos: ThreadStoreThreadInfos,
-): ThreadStoreThreadInfos {
-  const updatedThreadStoreInfos = { ...threadStoreInfos };
+// This migration utility can only be used with LegacyRawThreadInfos
+function legacyUpdateRolesAndPermissions(
+  threadStoreInfos: RawThreadInfos,
+): RawThreadInfos {
+  const updatedThreadStoreInfos = assertAllThreadInfosAreLegacy({
+    ...threadStoreInfos,
+  });
 
   const recursivelyUpdateRoles = (
     node: $ReadOnly<ThreadTraversalNode>,
@@ -166,4 +171,4 @@ function updateRolesAndPermissions(
   return updatedThreadStoreInfos;
 }
 
-export { updateRolesAndPermissions };
+export { legacyUpdateRolesAndPermissions };

native/redux/persist.js

@@ -101,11 +101,11 @@ import {
 } from './client-db-utils.js';
 import { defaultState } from './default-state.js';
 import { migrateThreadStoreForEditThreadPermissions } from './edit-thread-permission-migration.js';
+import { legacyUpdateRolesAndPermissions } from './legacy-update-roles-and-permissions.js';
 import { persistMigrationForManagePinsThreadPermission } from './manage-pins-permission-migration.js';
 import { persistMigrationToRemoveSelectRolePermissions } from './remove-select-role-permissions.js';
 import type { AppState } from './state-types.js';
 import { unshimClientDB } from './unshim-utils.js';
-import { updateRolesAndPermissions } from './update-roles-and-permissions.js';
 import { commCoreModule } from '../native-modules.js';
 import { defaultDeviceCameraInfo } from '../types/camera.js';
 import { isTaskCancelledError } from '../utils/error-handling.js';
@@ -600,10 +600,16 @@ const migrations = {
     return state;
   },
   [38]: (state: AppState) =>
-    updateClientDBThreadStoreThreadInfos(state, updateRolesAndPermissions),
+    updateClientDBThreadStoreThreadInfos(
+      state,
+      legacyUpdateRolesAndPermissions,
+    ),
   [39]: (state: AppState) => unshimClientDB(state, [messageTypes.EDIT_MESSAGE]),
   [40]: (state: AppState) =>
-    updateClientDBThreadStoreThreadInfos(state, updateRolesAndPermissions),
+    updateClientDBThreadStoreThreadInfos(
+      state,
+      legacyUpdateRolesAndPermissions,
+    ),
   [41]: (state: AppState) => {
     const queuedReports = state.reportStore.queuedReports.map(report => ({
       ...report,
@@ -979,7 +985,10 @@ const migrations = {
     return state;
   },
   [60]: (state: AppState) =>
-    updateClientDBThreadStoreThreadInfos(state, updateRolesAndPermissions),
+    updateClientDBThreadStoreThreadInfos(
+      state,
+      legacyUpdateRolesAndPermissions,
+    ),
 };
 
 // After migration 31, we'll no longer want to persist `messageStore.messages`

native/redux/update-roles-and-permissions.test.js

@@ -1,37 +1,39 @@
 // @flow
 
+import { legacyUpdateRolesAndPermissions } from './legacy-update-roles-and-permissions.js';
 import {
   threadStoreThreads,
   threadStoreThreadsWithEmptyRolePermissions,
   threadStoreThreadsWithEmptyRolePermissionsAndMemberPermissions,
   threadStoreThreadsWithEmptyRoleAndMemberAndCurrentUserPermissions,
 } from './update-roles-and-permissions-test-data.js';
-import { updateRolesAndPermissions } from './update-roles-and-permissions.js';
 
 describe.skip('updateRolesAndPermissions()', () => {
   it('should leave threadStoreThreads from server unchanged', () => {
-    expect(updateRolesAndPermissions(threadStoreThreads)).toStrictEqual(
+    expect(legacyUpdateRolesAndPermissions(threadStoreThreads)).toStrictEqual(
       threadStoreThreads,
     );
   });
 
   it('should construct role permissions when missing from existing store', () => {
     expect(
-      updateRolesAndPermissions(threadStoreThreadsWithEmptyRolePermissions),
+      legacyUpdateRolesAndPermissions(
+        threadStoreThreadsWithEmptyRolePermissions,
+      ),
     ).toStrictEqual(threadStoreThreads);
   });
 
   it('should construct role permissions AND member permissions when missing from existing store', () => {
     expect(
-      updateRolesAndPermissions(
+      legacyUpdateRolesAndPermissions(
         threadStoreThreadsWithEmptyRolePermissionsAndMemberPermissions,
       ),
     ).toStrictEqual(threadStoreThreads);
   });
 
   it('should construct role permissions AND member permissions AND current user permissions when missing from existing store', () => {
     expect(
-      updateRolesAndPermissions(
+      legacyUpdateRolesAndPermissions(
         threadStoreThreadsWithEmptyRoleAndMemberAndCurrentUserPermissions,
       ),
     ).toStrictEqual(threadStoreThreads);