-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implement SQLiteQueryExecutor method to create main compaction
Summary: This differential introduces SQLiteQueryExecutor method to create main compaction backup. It uses sqlite backup API via sqlite orm in order to be able to detect if a developer makes mistake and tries to call backup creation inside of a transaction. Additionally this differential introduces changes that allow us to create second sqlite orm storage object. It is necessary to be able to create backup that is encrypted with encryption key. Test Plan: 1. Add a call to main compaction creation in `SQLiteQueryExecutor::updateDraft` and remove a call to replace draft. 2. Update draft. 3. Download application container from XCode or examine device file expolorer in Android studio. 4. Ensure that backup file was created and it is encrypted. 5. Repeat steps above with encryption disabled. Ensure database content matches backup content. Reviewers: kamil, michal Reviewed By: kamil Subscribers: ashoat, tomek Differential Revision: https://phab.comm.dev/D10503
- Loading branch information
1 parent
3be9c9a
commit bfc117b
Showing
4 changed files
with
163 additions
and
71 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.