[lib] Don't created thin thread if call to identity server failed whe…

…n adding friends

Summary:
https://linear.app/comm/issue/ENG-9509/accepting-a-friend-request-on-web-creates-thin-thread

Related discussion: https://phab.comm.dev/D13940#389316
Now we're throwing an error just in useUpdateRelationships(), there are no changes in getUserIdentities()
and useUsersSupportThickThreads() returns Map instead of Set

Depends on D14022

Test Plan:
Throw some error in fetchUserIdentitiesPromise() so that finding user indentity always fails
Mobile user goes to profile -> Friend list and adds the web user as a friend
Before a thin thread was created. Now mobile user sees an alert, because there is no auxUserInfo, no thick thread and call to identity server fails.

Reviewers: kamil, tomek, ashoat

Reviewed By: ashoat

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D14023

lib/hooks/relationship-hooks.js

@@ -87,7 +87,7 @@ function useUpdateRelationships(): (
   );
   const createNewThickThread = useNewThickThread();
 
-  const filterUsersSupportingThickThreads = useUsersSupportThickThreads();
+  const mapUsersSupportingThickThreads = useUsersSupportThickThreads();
 
   const updateRelationshipsAndSendRobotext = React.useCallback(
     async (action: RelationshipAction, userIDs: $ReadOnlyArray<string>) => {
@@ -98,10 +98,13 @@ function useUpdateRelationships(): (
         return {};
       }
       const usersSupportingThickThreads =
-        await filterUsersSupportingThickThreads(userIDs);
+        await mapUsersSupportingThickThreads(userIDs);
       const planForUsers = new Map<string, RobotextPlanForUser>();
       for (const userID of userIDs) {
-        if (!usersSupportingThickThreads.has(userID)) {
+        if (usersSupportingThickThreads.get(userID) === undefined) {
+          throw new Error('Cannot fetch user identity');
+        }
+        if (!usersSupportingThickThreads.get(userID)) {
           planForUsers.set(userID, { plan: 'send_to_thin_thread' });
           continue;
         }
@@ -220,7 +223,7 @@ function useUpdateRelationships(): (
     [
       viewerID,
       updateRelationships,
-      filterUsersSupportingThickThreads,
+      mapUsersSupportingThickThreads,
       pendingToRealizedThreadIDs,
       sendRobotextToThickThread,
       userInfos,

lib/hooks/thread-search-hooks.js

@@ -106,7 +106,7 @@ function useThreadListSearch(
       filterAndSetUserResults(
         identitySearchUsers.map(search => ({
           ...search,
-          supportThickThreads: userIDsSupportingThickThreads.has(search.id),
+          supportThickThreads: !!userIDsSupportingThickThreads.get(search.id),
         })),
       );
     })();

lib/hooks/user-identities-hooks.js

@@ -7,18 +7,18 @@ import { useSelector } from '../utils/redux-utils.js';
 
 function useUsersSupportThickThreads(): (
   userIDs: $ReadOnlyArray<string>,
-) => Promise<$ReadOnlySet<string>> {
+) => Promise<$ReadOnlyMap<string, boolean | void>> {
   const findUserIdentities = useFindUserIdentities();
   const auxUserInfos = useSelector(state => state.auxUserStore.auxUserInfos);
 
   return React.useCallback(
     async (userIDs: $ReadOnlyArray<string>) => {
-      const usersSupportingThickThreads = new Set<string>();
+      const usersSupportingThickThreads = new Map<string, boolean | void>();
 
       const usersNeedingFetch = [];
       for (const userID of userIDs) {
         if (auxUserInfos[userID]?.deviceList) {
-          usersSupportingThickThreads.add(userID);
+          usersSupportingThickThreads.set(userID, true);
         } else {
           usersNeedingFetch.push(userID);
         }
@@ -27,7 +27,11 @@ function useUsersSupportThickThreads(): (
         const { identities } = await findUserIdentities(usersNeedingFetch);
         for (const userID of usersNeedingFetch) {
           if (identities[userID]) {
-            usersSupportingThickThreads.add(userID);
+            usersSupportingThickThreads.set(userID, true);
+          } else if (identities[userID] === undefined) {
+            usersSupportingThickThreads.set(userID, undefined);
+          } else {
+            usersSupportingThickThreads.set(userID, false);
           }
         }
       }

lib/shared/thread-utils.js

@@ -1790,7 +1790,7 @@ function useUserProfileThreadInfo(userInfo: ?UserInfo): ?UserProfileThreadInfo {
         return;
       }
       const result = await usersSupportThickThreads([userInfo.id]);
-      setSupportThickThreads(result.has(userInfo.id));
+      setSupportThickThreads(!!result.get(userInfo.id));
     })();
   }, [userInfo, usersSupportThickThreads]);
 

native/chat/message-list-container.react.js

@@ -299,7 +299,7 @@ const ConnectedMessageListContainer: React.ComponentType<BaseProps> =
         );
         setAllUsersSupportThickThreads(
           userInfoInputArray.every(userInfo =>
-            usersSupportingThickThreads.has(userInfo.id),
+            usersSupportingThickThreads.get(userInfo.id),
           ),
         );
       })();

web/chat/chat-thread-composer.react.js

@@ -115,7 +115,7 @@ function ChatThreadComposer(props: Props): React.Node {
           allUsersSupportThickThreads:
             user.id === viewerID
               ? true
-              : usersSupportingThickThreads.has(user.id),
+              : !!usersSupportingThickThreads.get(user.id),
         });
         dispatch({
           type: updateNavInfoActionType,

web/utils/thread-utils.js

@@ -88,7 +88,7 @@ function useThreadInfoForPossiblyPendingThread(
       );
       setAllUsersSupportThickThreads(
         selectedUserInfos.every(userInfo =>
-          usersSupportingThickThreads.has(userInfo.id),
+          usersSupportingThickThreads.get(userInfo.id),
         ),
       );
     })();