Remove o11yphant dependencies #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the o11yphant out of the whole dependency tree. Instead, it uses the native otel libs to do all tracing work. The metrics part will not use any legacy o11yphant metrics APIs, but just some simple meter as value which inject into the span attribute, like "client.folo.admin.latency".
It also removes bunch of legacy features which are not used in client tracing, like thread level span, GoldenSignalMetrics.
With this change, there will only be one root span for each client request lifecycle now.
Note that there are API changes for the Indy client setup because the old TraceManager and TraceConfiguration in o11yphant have been removed. So we need to change the API usage in Indy or somewhere else which uses the Indy-client