Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework TempleGateAllSwitches to use the DashSwitch's OnDashCollide instead of default OnDashed #47

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Rework TempleGateAllSwitches to use the DashSwitch's OnDashCollide instead of default OnDashed #47

merged 2 commits into from
Apr 26, 2024

Conversation

aonkeeper4
Copy link
Contributor

Rework TempleGateAllSwitches to use the DashSwitch's OnDashCollide delegate instead of the default OnDashed method. This change should make it robust if classes that extend DashSwitch override / don't use the default OnDashed method. The method used in this change should work as long as OnDashCollide isn't modified in Awake at all.

catapillie
catapillie approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@catapillie catapillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@catapillie catapillie merged commit d30d120 into CommunalHelper:dev Apr 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catapillie catapillie catapillie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aonkeeper4 @catapillie