Remove the second enable_dracut_fips_module in enable_fips_mode #12983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mab879
added
bugfix
Mab879
force-pushed
the
rhel_fips_clean_up2
branch
from
ed2fd77 to
b524ab6
Compare
|
Code Climate has analyzed commit b524ab6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
I have checked that the built OVALs for the rule enable_fips_mode don't contain any occurrence of dracut both on RHEL 9 and 10.
I have run test /hardening/container/bootc-image-builder/stig using autocontest on a remote RHEL 9.6 virtual machine and the rule enable_fips_mode has passed in the final scan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove the second
enable_dracut_fips_moduleinenable_fips_mode.Rationale:
So the rule passes.