-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully migrate file opeartions to using nio Path #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0c75ea
to
f94fc85
Compare
f94fc85
to
59d5d6d
Compare
egorikftp
reviewed
Jul 22, 2024
plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/dnd/DragAndDropHandler.kt
Outdated
Show resolved
Hide resolved
...ithub/composegears/valkyrie/ui/screen/mode/iconpack/destination/IconPackDestinationScreen.kt
Outdated
Show resolved
Hide resolved
egorikftp
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for improvement!
fec00b4
to
4e0aa6e
Compare
Goooler
commented
Jul 22, 2024
Goooler
commented
Jul 22, 2024
c0a5b55
to
365fee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path
, with higher performance and scalability.kotlinx-io-core
, there is no multiplatform need. This will also decrease the build artifact size.