Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set C++ compiler in PyPIConGPU tests to gcc 11 #5256

Conversation

SimeonEhrig
Copy link
Contributor

fix #5250

@SimeonEhrig
Copy link
Contributor Author

Looks like the change is working. Unfortunately the CI does not show the used gcc version, if everything works. But set the compiler with export CXX=$CXX_VERSION, it failed the first time because I used the wrong container image and the CI could not find gcc-13 and than I fixed it.

Waiting for review from @ikbuibui , if this PR fixes his problem.

@ikbuibui
Copy link
Contributor

ikbuibui commented Jan 28, 2025

Without checking against my PR it seems like it is still GCC 9 that is used in the CI. This is the pypicongpu-compiling-test from the CI of this PR - https://gitlab.com/hzdr/crp/picongpu/-/jobs/8967984161
But I think with #5255 this problem should be automatically be solved

@SimeonEhrig
Copy link
Contributor Author

Without checking against my PR it seems like it is still GCC 9 that is used in the CI. This is the pypicongpu-compiling-test from the CI of this PR - https://gitlab.com/hzdr/crp/picongpu/-/jobs/8967984161 But I think with #5255 this problem should be automatically be solved

The host compiler (GCC 9) is only used to install the dependencies. For the actual Python tests, it uses the compiler which was specified. The PR #5255 does not solve the problem, because it does not use export CXX=CXX_VERSION.

Copy link
Contributor

@ikbuibui ikbuibui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that it successfully works in #5249

@ikbuibui ikbuibui merged commit 527ef1e into ComputationalRadiationPhysics:dev Jan 28, 2025
10 checks passed
@ikbuibui ikbuibui added this to the 0.9.0 / next stable milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pypicongpu compile test compiles with GCC9
2 participants