Added cmake constraint. Force our dummy wheel or fail for version above. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hum, I just thought that we need to have a separate constraint file for build-node, otherwise this will eventually make its way to production without having the actual dummy wheel on clusters. |
|
Hmm ok, then we can let this PR rest until then |
Added `constraints-cmake.txt` file Keep but emptied `constraints-buildnode.txt` in case we like to add new constraints only on build-node Updated 2020 and 2023 pip config files to use constraints-cmake.txt file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake Python wheel are duplicate of the system cmake, in order for python packages to build with cmake, it provides
cmake,cpackandctestbinariesHaving cmake wheels are unnecessary and takes a very long time to build, and fails randomly sometimes
Having a dummy wheel where we constraint pip to install our dummy wheel (
3.23.1) or fail if a version above our module is requested.Meet the requirements :
cmake,cmake<3.24,cmake>3.21Fails when :
cmake==3.22. We then need to sed the build requirement this is not oftencmake>3.27. Means we need to install that version has some specific features might be used.