Fix gcp format #198
Merged
Fix gcp format #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radiokot
approved these changes
Aug 28, 2024
soerenbf
approved these changes
Aug 28, 2024
| @@ -397,7 +397,7 @@ mod tests { | |||
| "amount": "200", | |||
| "type": "cis2-tx", | |||
| "token_id": "ffffff", | |||
| "contract_address": {"index": 3, "subindex": 0}, | |||
| "contract_address": "{\"index\":3,\"subindex\":0}", | |||
There was a problem hiding this comment.
Lame... but if that's what it has to be, I guess there's no way around it 🤷
There was a problem hiding this comment.
Wasn't it you who suggested using JSON for contract address? :)
There was a problem hiding this comment.
yes but I would assume the whole request being JSON would be sufficient 😛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://firebase.google.com/docs/reference/fcm/rest/v1/projects.messages#Message
Data only allows for String and String.
This means we need to take ownership of some of the types
Changes
Changed serialisation for those fields which did not return a string
Checklist
hard-to-understand areas.