Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAL2-89 Remove shielding #335

Merged
merged 11 commits into from
May 30, 2024
Merged

WAL2-89 Remove shielding #335

merged 11 commits into from
May 30, 2024

Conversation

Radiokot
Copy link
Member

@Radiokot Radiokot commented May 15, 2024

Purpose

Remove shielding. The user can still enable and see their shielded balance and history, but to unshield the funds CryptoX Concordium wallet must be used.

Changes

  • Visually remove shielding actions (transfer, shield, unshield)
  • Add shielding notice popup shown once

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Copy link

File Coverage [0%]
AccountSettingsActivity.kt 0%
Total Project Coverage 1.01%

Copy link

File Coverage [0%]
AccountSettingsActivity.kt 0%
AccountDetailsViewModel.kt 0%
Total Project Coverage 1.01%

Copy link

File Coverage [0%]
AccountSettingsActivity.kt 0%
AccountDetailsViewModel.kt 0%
AccountsOverviewFragment.kt 0%
Total Project Coverage 1.02%

@Radiokot Radiokot marked this pull request as ready for review May 20, 2024 15:07
@Radiokot Radiokot requested a review from ramakser May 20, 2024 15:15
Copy link

File Coverage [0%]
AccountSettingsActivity.kt 0%
AccountDetailsViewModel.kt 0%
AccountsOverviewFragment.kt 0%
Total Project Coverage 1.02%

@Radiokot Radiokot marked this pull request as draft May 24, 2024 09:34
Copy link

File Coverage [0%]
AccountsOverviewFragment.kt 0%
ShieldingNoticeDialogFragment.kt 0%
PassPhraseRecoverViewModel.kt 0%
Total Project Coverage 1.01%

Copy link

File Coverage [0.35%]
AuthPreferences.kt 4.58%
Session.kt 0%
AccountDetailsActivity.kt 0%
Account.kt 0%
AccountsOverviewViewModel.kt 0%
AccountsOverviewFragment.kt 0%
ShieldingNoticeDialogFragment.kt 0%
PassPhraseRecoverViewModel.kt 0%
Total Project Coverage 1.01%

Detect empty shielded balances in the recovery process.
@Radiokot Radiokot marked this pull request as ready for review May 28, 2024 14:36
Copy link

File Coverage [0.23%]
AuthPreferences.kt 4.58%
AccountEncryptedAmount.kt 0%
AccountUpdater.kt 0%
RecoverProcessViewModel.kt 0%
Session.kt 0%
AccountDetailsActivity.kt 0%
Account.kt 0%
AccountsOverviewViewModel.kt 0%
AccountsOverviewFragment.kt 0%
ShieldingNoticeDialogFragment.kt 0%
PassPhraseRecoverViewModel.kt 0%
Total Project Coverage 1.01%

@Radiokot Radiokot merged commit 45ba3a6 into main May 30, 2024
1 check passed
@Radiokot Radiokot deleted the feature/WAL2-89-remove-shielded-txs branch May 30, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants