[Rust] Double Ack (Ack Ack) #241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for nats-by-example ready! ✅ Preview Built with commit 2ab081b. |
Jarema
requested changes
Jul 30, 2024
| println!("Consumer 1"); | ||
| println!(" Start\n # pending messages: {}\n # messages with ack pending: {}", ci.num_pending, ci.num_ack_pending); | ||
|
|
||
| let message = consumer.fetch().max_messages(1).messages().await?.next().await.unwrap()?; |
There was a problem hiding this comment.
I would not unwrap the optional without comment here.
Let's explain to the user what is happening here: that messages() returns an iterator that is closed when None is returned.
maybe this is giving the user a better idea what is happening?
let fetch = consumer.fetch().max_messages(1).messages().await?;
let message = match fetch.next().await.expect("should get one message");| // Consumer 2 will use double_ack() | ||
| let stream = jetstream.get_stream("EVENTS".to_string()).await?; | ||
| let mut consumer = stream | ||
| .create_consumer(async_nats::jetstream::consumer::pull::Config { ..Default::default()}) |
There was a problem hiding this comment.
I would put an explicit name for the consumer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.