Improve confirmed ack Go example #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version had few things that could be improved: 1. Unnecessary details on stream, which are outlined in stream examples. 2. Explicitly handling errors, while other examples ignore them for easier readability. 3. Example was not fetching fresh info, which then printed that the ack was not yet processed, which was not true. 4. Added more explanation on difference between ack and confirmed ack. Signed-off-by: Tomasz Pietrek <[email protected]>
|
Deploy preview for nats-by-example ready! ✅ Preview Built with commit 798bf0c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version had few things that could be improved:
Signed-off-by: Tomasz Pietrek [email protected]