Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nbe genereate --recreate in githhub action #273

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexbozhenko
Copy link

@alexbozhenko alexbozhenko commented Dec 11, 2024

After removing all the outputs:

find . -name output.cast -or  -name output.txt | xargs rm
nbe generate recording   --recreate

I see that the following files are not recreated, meaning the examples are failing to build or regeneration is not happening for some other reason...:

[alex@omenlaptop nats-by-example]$ git status | grep deleted | grep \.txt
        deleted:    examples/auth/nkeys-jwts/go/output.txt
        deleted:    examples/embedded/mtls/go/output.txt
        deleted:    examples/jetstream/ack-ack/csharp/output.txt
        deleted:    examples/jetstream/ack-ack/go/output.txt
        deleted:    examples/jetstream/api-migration/dotnet/output.txt
        deleted:    examples/jetstream/api-migration/go/output.txt
        deleted:    examples/jetstream/interest-stream/csharp/output.txt
        deleted:    examples/jetstream/interest-stream/go/output.txt
        deleted:    examples/jetstream/limits-stream/csharp/output.txt
        deleted:    examples/jetstream/limits-stream/go/output.txt
        deleted:    examples/jetstream/limits-stream/node/output.txt
        deleted:    examples/jetstream/limits-stream/rust/output.txt
        deleted:    examples/jetstream/list-subjects/csharp/output.txt
        deleted:    examples/jetstream/list-subjects/go/output.txt
        deleted:    examples/jetstream/pull-consumer-limits/csharp/output.txt
        deleted:    examples/jetstream/pull-consumer-limits/go/output.txt
        deleted:    examples/jetstream/pull-consumer/csharp/output.txt
        deleted:    examples/jetstream/pull-consumer/go/output.txt
        deleted:    examples/jetstream/workqueue-stream/csharp/output.txt
        deleted:    examples/jetstream/workqueue-stream/go/output.txt
        deleted:    examples/kv/intro/csharp/output.txt
        deleted:    examples/kv/intro/go/output.txt
        deleted:    examples/messaging/concurrent/csharp/output.txt
        deleted:    examples/messaging/iterating-multiple-subscriptions/csharp/output.txt
        deleted:    examples/messaging/json/csharp/output.txt
        deleted:    examples/messaging/protobuf/csharp/output.txt
        deleted:    examples/messaging/pub-sub/csharp/output.txt
        deleted:    examples/messaging/pub-sub/node/output.txt
        deleted:    examples/messaging/request-reply/csharp/output.txt
        deleted:    examples/os/intro/csharp/output.txt
        deleted:    examples/services/intro/csharp/output.txt

This change will trigger image rebuild and will exercise all the examples to catch broken builds.

When --exit-on-error was added in
https://github.com/ConnectEverything/nats-by-example/pull/81/files by @scottf
was the idea to use the generate command as a way of running tests?

@alexbozhenko alexbozhenko requested a review from bruth January 14, 2025 22:22
@alexbozhenko
Copy link
Author

Also, because --recreate is not passed
E.g. this was landed:
#189
but old screencast is till there:
https://natsbyexample.com/examples/jetstream/limits-stream/python

@alexbozhenko alexbozhenko requested review from Jarema and removed request for bruth January 15, 2025 21:25
@scottf scottf requested a review from bruth January 16, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant