Include information about why publishing the attestation failed in re…

…sponse (#6332)
Consensys · Oct 21, 2022 · 02fd0a7 · 02fd0a7
1 parent c9bf8e9
commit 02fd0a7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/beacon/validator/build.gradle b/beacon/validator/build.gradle
@@ -25,6 +25,7 @@ dependencies {
   implementation project(':data:serializer')
   implementation project(':data:provider')
   implementation project(':infrastructure:events')
+  implementation project(':infrastructure:exceptions')
   implementation project(':infrastructure:metrics')
 
   implementation 'it.unimi.dsi:fastutil'

diff --git a/.../validator/src/main/java/tech/pegasys/teku/validator/coordinator/ValidatorApiHandler.java b/.../validator/src/main/java/tech/pegasys/teku/validator/coordinator/ValidatorApiHandler.java
@@ -15,6 +15,7 @@
 
 import static java.util.stream.Collectors.toList;
 import static java.util.stream.Collectors.toMap;
+import static tech.pegasys.teku.infrastructure.exceptions.ExceptionUtil.getMessageOrSimpleName;
 import static tech.pegasys.teku.infrastructure.logging.ValidatorLogger.VALIDATOR_LOGGER;
 import static tech.pegasys.teku.spec.config.SpecConfig.GENESIS_SLOT;
 
@@ -493,10 +494,18 @@ private SafeFuture<InternalValidationResult> processAttestation(final Attestatio
               }
             })
         .exceptionally(
-            error ->
-                InternalValidationResult.reject(
-                    "Failed to send signed attestation for slot %s, block %s",
-                    attestation.getData().getSlot(), attestation.getData().getBeaconBlockRoot()));
+            error -> {
+              LOG.error(
+                  "Failed to send signed attestation for slot {}, block {}",
+                  attestation.getData().getSlot(),
+                  attestation.getData().getBeaconBlockRoot(),
+                  error);
+              return InternalValidationResult.reject(
+                  "Failed to send signed attestation for slot %s, block %s: %s",
+                  attestation.getData().getSlot(),
+                  attestation.getData().getBeaconBlockRoot(),
+                  getMessageOrSimpleName(error));
+            });
   }
 
   private List<SubmitDataError> convertAttestationProcessingResultsToErrorList(