feat: Remove stale validator keys during reload #1054
Conversation
usmansaleem
added
the
doc-change-required
signing/src/main/java/tech/pegasys/web3signer/signing/config/DefaultArtifactSignerProvider.java
Outdated
Show resolved
Hide resolved
signing/src/main/java/tech/pegasys/web3signer/signing/config/DefaultArtifactSignerProvider.java
Outdated
Show resolved
Hide resolved
...src/main/java/tech/pegasys/web3signer/slashingprotection/PostLoadingValidatorsProcessor.java
Outdated
Show resolved
Hide resolved
…ng logic to avoid clearing the map. Also made sure maps are thread-safe by using concurrent maps
CHANGELOG.md
Outdated
| The reload API call will remove all in-memory keys before loading them again using configuration files and bulk loading. | ||
| This unfortunately results in behaviour change of local configuration files pointing to encrypted keystores. Previously | ||
| cached local configuration files were avoided being reloaded during reload API call, now they will be reloaded and | ||
| reparsed. To keep the old behavior `--reload-keep-stale-keys=true` option can be used which will not remove stale keys | ||
| during reload API call. |
There was a problem hiding this comment.
Is this still true after the latest changes?
There was a problem hiding this comment.
The wording need to change a bit, but we are still loading all the local keystores during the reload because otherwise we won't be able to figure out which keystores are removed. Let me go through the local keystores logic again.
| cached local configuration files were avoided being reloaded during reload API call, now they will be reloaded and | ||
| reparsed. To keep the old behavior `--reload-keep-stale-keys=true` option can be used which will not remove stale keys | ||
| during reload API call. | ||
|
|
There was a problem hiding this comment.
Should also add a note about the deprecated vertx pool size option being removed
| private final Optional<KeystoresParameters> commitBoostKeystoresParameters; | ||
|
|
||
| private final ConcurrentMap<String, ArtifactSigner> signers = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
What impact does switching to ConcurrentMap have on the startup time for Web3Signer when we have a lot of keys?
There was a problem hiding this comment.
I will create a performance test (outside of this PR) loading of about 5000 fully encrypted keystores load time at start up.
PR Description
Remove stale validator keys during reload API call. The stale keys will not be listed in public keys API call after reload. They are also disabled in slashing database in eth2 mode.
Fixed Issue(s)
Fixes #1018
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Testing